Skip to content

refactor(ingest): use typed objects in dbt ingestion #5929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 16, 2022
Merged

refactor(ingest): use typed objects in dbt ingestion #5929

merged 5 commits into from
Sep 16, 2022

Conversation

hsheth2
Copy link
Contributor

@hsheth2 hsheth2 commented Sep 13, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Sep 13, 2022
@github-actions
Copy link

github-actions bot commented Sep 13, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   55m 32s ⏱️
   707 tests    704 ✔️ 3 💤 0 ❌
1 414 runs  1 408 ✔️ 6 💤 0 ❌

Results for commit 9c28fda.

♻️ This comment has been updated with latest results.

@hsheth2 hsheth2 marked this pull request as ready for review September 14, 2022 00:27
@github-actions
Copy link

github-actions bot commented Sep 14, 2022 •
edited
Loading

Unit Test Results (build & test)

571 tests   571 ✔️  14m 56s ⏱️
141 suites      0 💤
141 files        0 ❌

Results for commit 9c28fda.

♻️ This comment has been updated with latest results.

@hsheth2 hsheth2 requested a review from rslanka September 14, 2022 16:32
@hsheth2 hsheth2 mentioned this pull request Sep 16, 2022
Merged
5 tasks
rslanka
rslanka reviewed Sep 16, 2022
View reviewed changes
rslanka
rslanka approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@rslanka rslanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsheth2 hsheth2 merged commit c8cd7d5 into datahub-project:master Sep 16, 2022
@hsheth2 hsheth2 deleted the dbt-refactor branch September 16, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rslanka rslanka rslanka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @rslanka