Skip to content

Conversation

jeffmerrick
Copy link
Contributor

The docusaurus version update changed the class names on the announcement bar which broke the custom styles for it. Adjusting the selector brought back the styles. Also updated the link url while I was in there.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions
Copy link

github-actions bot commented Sep 22, 2022

Unit Test Results (build & test)

562 tests   562 ✔️  12m 50s ⏱️
139 suites      0 💤
139 files        0

Results for commit 285ecea.

♻️ This comment has been updated with latest results.

@hsheth2
Copy link
Contributor

hsheth2 commented Sep 22, 2022

Thanks @jeffmerrick - it mostly looks good, but the announcement bar seems to cover the search bar on mobile
image

@hsheth2 hsheth2 self-assigned this Sep 22, 2022
@jeffmerrick
Copy link
Contributor Author

@hsheth2 Added a fix! It was covering the mobile nav too. Looks like the official Docusaurus docs have the same bug.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeff!

@shirshanka shirshanka merged commit 1ff6cce into datahub-project:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants