Skip to content

Conversation

dweinholz
Copy link
Contributor

…can be used but aren't required

Try to fulfill the following points before the Pull Request is merged:

  • The PR is reviewed by one of the team members.
  • If a linting PR exists, it must be merged before this PR is allowed to be merged.
  • If the PR is merged in the master then a release should be be made.
  • If the new code is readable, if not it should be well commented

For releases only:

  • If the review of this PR is approved and the PR is followed by a release then the .env file
    in the cloud-portal repo should also be updated.
  • If you are making a release then please sum up the changes since the last release on the release page using the clog tool with clog -F

@dweinholz dweinholz requested a review from vktrrdk May 6, 2025 14:04
Copy link
Contributor

github-actions bot commented May 6, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
simple_vm_client
   VirtualMachineHandler.py209118118 44%
   __init__.py10100% 
   test_virtualmachinehandler.py306195195 36%
simple_vm_client/benchmark
   __init__.py00100% 
   test_service.py523636 31%
simple_vm_client/bibigrid_connector
   __init__.py00100% 
   bibigrid_connector.py121106106 12%
   test_bibigrid_connector.py173156156 10%
simple_vm_client/forc_connector
   __init__.py00100% 
   forc_connector.py290247247 15%
simple_vm_client/forc_connector/playbook
   __init__.py00100% 
   playbook.py190159159 16%
   test_playbook.py381282282 26%
simple_vm_client/forc_connector/template
   __init__.py00100% 
   template.py227148148 35%
simple_vm_client/metadata_connector
   metadata_connector.py887171 19%
simple_vm_client/openstack_connector
   __init__.py00100% 
   openstack_connector.py974855855 12%
   test_openstack_connector.py1256960960 24%
simple_vm_client/util
   __init__.py00100% 
   state_enums.py700100% 
   test_thrift_converter.py170143143 16%
   thrift_converter.py806161 24%
TOTAL4588353723% 

Tests Skipped Failures Errors Time
1 0 💤 0 ❌ 1 🔥 2.615s ⏱️

@vktrrdk vktrrdk merged commit 79ce830 into dev May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants