Inline type stubs from typeshed #172
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #166
Stubs are taken from: https://github.com/python/typeshed/tree/main/stubs/olefile/olefile
Other changes:
sys.version_info
to do Python2 vs Python3 branching, then MyPy doesn't require extratype: ignore
s (it's also probably more robust?)Advantages of having the type stubs inlined are:
pip install olefile
, they get the stubs automatically