feat: Add Together AI integration #2268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:CI
type:documentation
Amnah199
changed the title
Generator and ChatGenerator
julian-risch
requested changes
Sep 15, 2025
There was a problem hiding this comment.
Looks quite good to me already! I have a couple of change requests, most of them with suggestions of code changes. In addition, the repo README should list the integration https://github.com/deepset-ai/haystack-core-integrations/blob/main/README.md
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Show resolved
Hide resolved
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Outdated
Show resolved
Hide resolved
integrations/together_ai/tests/test_together_ai_chat_generator.py
Outdated
Show resolved
Hide resolved
...rations/together_ai/src/haystack_integrations/components/generators/together_ai/generator.py
Outdated
Show resolved
Hide resolved
...rations/together_ai/src/haystack_integrations/components/generators/together_ai/generator.py
Outdated
Show resolved
Hide resolved
...rations/together_ai/src/haystack_integrations/components/generators/together_ai/generator.py
Outdated
Show resolved
Hide resolved
...gether_ai/src/haystack_integrations/components/generators/together_ai/chat/chat_generator.py
Show resolved
Hide resolved
|
Sorry for all the baseless typos in this PR! Will request review again once I have tested the component in deepset platform. |
Amnah199
commented
Sep 16, 2025
| tools: Optional[Union[List[Tool], Toolset]] = None, | ||
| timeout: Optional[float] = None, | ||
| max_retries: Optional[int] = None, | ||
| http_client_kwargs: Optional[Dict[str, Any]] = None, |
There was a problem hiding this comment.
Wondering whether we need this param http_client_kwargs here. Its compatible but not sure if it adds any value for this integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Add a new integration for TogetherAI that inherits from
OpenAIChatGeneratorHow did you test it?
Add new tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.