Skip to content

chore!: remove deprecated BedrockRanker (use AmazonBedrockRanker instead) #2287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2025
Merged

chore!: remove deprecated BedrockRanker (use AmazonBedrockRanker instead) #2287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53154e9
chore: remove legacy BedrockRanker (use AmazonBedrockRanker instead)
anakin87 Sep 18, 2025
9409b21
fmt
anakin87 Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ns/amazon_bedrock/src/haystack_integrations/components/rankers/amazon_bedrock/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from .ranker import AmazonBedrockRanker, BedrockRanker
from .ranker import AmazonBedrockRanker

__all__ = ["AmazonBedrockRanker", "BedrockRanker"]
__all__ = ["AmazonBedrockRanker"]
18 changes: 0 additions & 18 deletions ...ions/amazon_bedrock/src/haystack_integrations/components/rankers/amazon_bedrock/ranker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import warnings
from typing import Any, Dict, List, Optional

from botocore.exceptions import ClientError
Expand Down Expand Up @@ -265,20 +264,3 @@ def resolve_secret(secret: Optional[Secret]) -> Optional[str]:
except Exception as exception:
msg = f"Error during Amazon Bedrock API call: {exception}"
raise AmazonBedrockInferenceError(msg) from exception


class BedrockRanker(AmazonBedrockRanker):
"""
Deprecated alias for AmazonBedrockRanker.
This class will be removed in a future version.
Please use AmazonBedrockRanker instead.
"""

def __init__(self, *args, **kwargs):
warnings.warn(
"BedrockRanker is deprecated and will be removed in a future version. "
"Please use AmazonBedrockRanker instead.",
DeprecationWarning,
stacklevel=2,
)
super().__init__(*args, **kwargs)
4 changes: 2 additions & 2 deletions integrations/amazon_bedrock/tests/test_ranker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from haystack_integrations.common.amazon_bedrock.errors import (
AmazonBedrockInferenceError,
)
from haystack_integrations.components.rankers.amazon_bedrock import AmazonBedrockRanker, BedrockRanker
from haystack_integrations.components.rankers.amazon_bedrock import AmazonBedrockRanker


@pytest.fixture
Expand All @@ -31,7 +31,7 @@ def test_amazon_bedrock_ranker_initialization(mock_aws_session):


def test_bedrock_ranker_run(mock_aws_session):
ranker = BedrockRanker(
ranker = AmazonBedrockRanker(
model="cohere.rerank-v3-5:0",
top_k=2,
aws_access_key_id=Secret.from_token("test_access_key"),
Expand Down
Loading