fix: using state provided in args in merge op #3522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gtrawinski <[email protected]>
gtrawinski
requested review from
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
Signed-off-by: gtrawinski <[email protected]>
ion-elgreco
approved these changes
Jun 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3522 +/- ##
==========================================
- Coverage 74.24% 74.22% -0.02%
==========================================
Files 150 150
Lines 44733 44732 -1
Branches 44733 44732 -1
==========================================
- Hits 33210 33203 -7
+ Misses 9376 9375 -1
- Partials 2147 2154 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows to control SessionState in the merge function (similarly as in update or delete ops).
We've tested this change on our fork and with memory limit set in SessionContext the usage dropped by a half with no visible impact on the jobs. That might help services potentially running out of memory and panicking. That might result in killing all connections with no warning/tracing.
Related Issue(s)
Documentation