Skip to content

Conversation

zachschuermann
Copy link
Member

Description

Write "engineInfo": "delta-rs:0.26.2" (or whatever current version is) in commitInfo action during writes. This will generally assist in debugging to understand what version of delta-rs wrote to tables at different points in time.

Related Issue(s)

Documentation

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jul 9, 2025
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.42%. Comparing base (e5971cf) to head (3f919d1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3584      +/-   ##
==========================================
- Coverage   74.45%   74.42%   -0.04%     
==========================================
  Files         146      146              
  Lines       44616    44617       +1     
  Branches    44616    44617       +1     
==========================================
- Hits        33221    33207      -14     
- Misses       9250     9251       +1     
- Partials     2145     2159      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Zach Schuermann <[email protected]>
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roeap roeap enabled auto-merge July 9, 2025 18:24
@roeap roeap added this pull request to the merge queue Jul 9, 2025
Merged via the queue into delta-io:main with commit 6eed6b4 Jul 9, 2025
26 checks passed
@ion-elgreco
Copy link
Collaborator

Hmm we already set it actually here

        app_metadata.insert(
            "clientVersion".to_string(),
            Value::String(format!("delta-rs.{}", crate_version())),

@roeap
Copy link
Collaborator

roeap commented Jul 9, 2025

@ion-elgreco - i was sure we had it, but somehow missed it. I'll consolidate in a follow-up.

@zachschuermann
Copy link
Member Author

hey sorry for missing that! thanks @ion-elgreco!

I was still hoping for this being specifically in commitInfo.engineInfo since some existing implementations already parse the string in that field and expose it in e.g. DESCRIBE HISTORY

@ion-elgreco
Copy link
Collaborator

hey sorry for missing that! thanks @ion-elgreco!

I was still hoping for this being specifically in commitInfo.engineInfo since some existing implementations already parse the string in that field and expose it in e.g. DESCRIBE HISTORY

We can also keep it there and remove it from appmetadata, but then I hope people are not relying on this info there for other reasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants