Skip to content

Conversation

corwinjoy
Copy link
Contributor

Description

Update the delta_table.vacuum command to add a keep_versions argument to specify versions to retain when performing a vacuum operation.

Related Issue(s)

Closes #3634
See the underlying Rust feature: #3537

@corwinjoy corwinjoy requested a review from ion-elgreco as a code owner July 29, 2025 01:37
@github-actions github-actions bot added the binding/python Issues for the Python package label Jul 29, 2025
@corwinjoy
Copy link
Contributor Author

via copilot:

Pull Request Overview

This PR adds a new keep_versions parameter to the vacuum command for Python, allowing users to specify specific table versions whose files should be preserved during vacuum operations.

Key changes:

  • Added keep_versions parameter to vacuum method signatures
  • Updated vacuum implementation to handle the new parameter
  • Added comprehensive test coverage for the new functionality

@corwinjoy
Copy link
Contributor Author

@rtyler @adamreeve
This should add the missing piece to access the new keep_versions feature from Python.
I'm not sure if I need to update any docs for the new function signature?

Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.44%. Comparing base (bc0fba8) to head (1fb13cd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
python/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3635      +/-   ##
==========================================
- Coverage   75.45%   75.44%   -0.02%     
==========================================
  Files         146      146              
  Lines       44901    44905       +4     
  Branches    44901    44905       +4     
==========================================
- Hits        33879    33877       -2     
- Misses       9204     9210       +6     
  Partials     1818     1818              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ion-elgreco ion-elgreco added this pull request to the merge queue Jul 29, 2025
Merged via the queue into delta-io:main with commit a51d16e Jul 29, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: update python table vacuum to add keep_versions parameter
2 participants