Skip to content

Conversation

david-bonhagen
Copy link
Contributor

@david-bonhagen david-bonhagen commented Aug 13, 2025

  • Refactored bin/typo3 path and improved documentation
  • Docs added?

This PR updates the TYPO3 Deployer recipe to standardize CLI calls using {{bin/typo3}} instead of hard-coded paths, ensuring compatibility with custom composer settings. Also inline PHPDoc comments and a usage example at the top of the file were included to improve maintainability and make the deployment process clearer for future developers.

@david-bonhagen david-bonhagen mentioned this pull request Aug 13, 2025
5 tasks
@MarcoRemy
Copy link
Contributor

Hi David, i tested the changes. Now it's working fine.

But there is something else missing: The TYPO3 recipe does not include the crucial deploy:symlink task, which symlinks the finished release to {{current_path}} (default: current).

task('deploy', [
    'deploy:info',
    'deploy:setup',
    'deploy:lock',
    'deploy:release',
    'typo3:update_code',
    'deploy:shared',
    'deploy:writable',
    'deploy:vendors',
    'typo3:cache:warmup',
    'typo3:extension:setup',
    'typo3:language:update',
    'typo3:cache:flush',
    // MISSING deploy:symlink
    'deploy:unlock',
    'deploy:cleanup',
    'deploy:success',
]);

The least tasks can be replaced with deploy:publish. It combines final tasks.

// recipe/common.php
task('deploy:publish', [
    'deploy:symlink',
    'deploy:unlock',
    'deploy:cleanup',
    'deploy:success',
]);

@MarcoRemy
Copy link
Contributor

Any update on this?

Copy link
Contributor

@MarcoRemy MarcoRemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In recipe/typo3.php replace lines 216-218 with deploy:publish or put deploy:symlink before

@MarcoRemy
Copy link
Contributor

@antonmedv please merge this PR. I will create a fix for the missing task.

@antonmedv antonmedv merged commit 11e97a2 into deployphp:master Sep 17, 2025
6 checks passed
@MarcoRemy MarcoRemy mentioned this pull request Sep 17, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants