Skip to content

Improve usability of AudioChannel #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2022
Merged

Improve usability of AudioChannel #2252

merged 4 commits into from
Sep 19, 2022

Conversation

MinnDevelopment
Copy link
Member

@MinnDevelopment MinnDevelopment commented Sep 18, 2022 •
edited
Loading

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

  1. Adds an AudioChannelUnion to simplify some code paths.
  2. Make AudioChannel a StandardGuildChannel which adds:
    • Invites
    • Category getter
    • Permissions
    • Positions
    • Copying

@MinnDevelopment MinnDevelopment changed the title Add AudioChannelUnion Improve usability of AudioChannel Sep 18, 2022
devoxin
devoxin reviewed Sep 18, 2022
View reviewed changes
@MinnDevelopment @devoxin
Fix typo
ded7710 
Co-authored-by: Devoxin <[email protected]>
DV8FromTheWorld
DV8FromTheWorld approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@DV8FromTheWorld DV8FromTheWorld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the above, this LGTM.
Ship it! :shipit:

@MinnDevelopment MinnDevelopment merged commit 0917474 into master Sep 19, 2022
@MinnDevelopment MinnDevelopment deleted the patch-audiochannel branch September 19, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

+1 more reviewer

@devoxin devoxin devoxin left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MinnDevelopment @DV8FromTheWorld @devoxin