Skip to content

Fix some checks not throwing the intended exception #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2022
Merged

Fix some checks not throwing the intended exception #2260

merged 3 commits into from
Sep 25, 2022

Conversation

MinnDevelopment
Copy link
Member

@MinnDevelopment MinnDevelopment commented Sep 25, 2022 •
edited
Loading

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

This corrects the exception thrown for owner checks in a few places. This was unintentionally changed to throw IllegalArgumentException, however it should throw HieararchyException.

There also was a wrong annotation in Member#timeoutUntil.

sebm253
sebm253 reviewed Sep 25, 2022
View reviewed changes
@MinnDevelopment MinnDevelopment merged commit c139953 into master Sep 25, 2022
@MinnDevelopment MinnDevelopment deleted the fix/owner-check branch September 25, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sebm253 sebm253 sebm253 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MinnDevelopment @sebm253