Skip to content

Fix MemberCacheViewImpl#getElementsWithRoles and Guild#findMembersWithRoles ignoring the public role #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 29, 2022
Merged

Fix MemberCacheViewImpl#getElementsWithRoles and Guild#findMembersWithRoles ignoring the public role #2297

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0039ef9
Fix MemberCacheViewImpl#getElementsWithRoles ignoring the public role
Almighty-Satan Oct 24, 2022
5172a94
Fix Guild#findMembersWithRoles
Almighty-Satan Oct 24, 2022
2480ef9
Check if the given roles belong to a different guild
Almighty-Satan Oct 24, 2022
f5c797e
Add missing check
Almighty-Satan Oct 24, 2022
16eb207
Add another missing check
Almighty-Satan Oct 24, 2022
cf3a154
Change noneNull to notNull
Almighty-Satan Oct 24, 2022
b34ecc0
Add new lines
Almighty-Satan Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/net/dv8tion/jda/api/entities/Guild.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,6 +1234,7 @@ default List<Member> getMembersByEffectiveName(@Nonnull String name, boolean ign
@Nonnull
default List<Member> getMembersWithRoles(@Nonnull Role... roles)
{
Checks.noneNull(roles, "Roles");
return getMembersWithRoles(Arrays.asList(roles));
}

Expand Down