DolphinQt: Reduce maximum initial dialog size to 75% of the screen dimensions. #13918
Conversation
|
While this works well for large devices, smaller screens (such as a steamdeck) need to fill the screen, so this won't be great there. Users can just enlarge the window of course and it would be better to have a proper solution for such devices (working on it) but that is how it is at the moment. |
Would it be sensible to use different factors depending on the screen's dimensions? For anything smaller than 1920x1080, 90% could be used. EDIT: I have implemented that check: for FullHD or greater resolutions, 75% is used. Otherwise the current 90% factor continues to be sued to not change behavior in handheld devices (although I can imagine how users would still want to maximize the dialog anyway). |
cristian64
force-pushed
the
reduce_dialog_initial_size
branch
from
c990e91 to
ce79ecf
Compare
…mensions. The maximum size for the initial size in dialogs has been reduced from 90% to 75% of the screen dimensions for screen resolutions greater than FullHD (`1920x1080`). Rationale: Almost no dialog in the application requires such a tall window resolution (an exception is the **Graphics > Advanced** pane in the **Settings** dialog). The reduced size prevents dialogs from appearing close to the edges of the screen, which was _opinionatedly_ not too elegant. | Before | After | | ------ | ----- | | <img width="1920" height="1080" alt="[Dolphin Emulator] Overly long Settings dialog" title="[Dolphin Emulator] Overly long Settings dialog" src="https://github.com/user-attachments/assets/0c5ecded-68bf-46e2-8696-399b2f263345" /> | <img width="1920" height="1080" alt="[Dolphin Emulator] Reduced Settings dialog" title="[Dolphin Emulator] Reduced Settings dialog" src="https://github.com/user-attachments/assets/45a63f2f-a7a7-4663-bacf-96d4172d42bf" /> | Devices with smaller screen resolutions (generally handheld devices) will continue to use a 90% factor of the screen dimensions.
cristian64
force-pushed
the
reduce_dialog_initial_size
branch
from
ce79ecf to
79b65f9
Compare
I think this is somewhat weird behavior. I think it's working around the real problem of |
Even if the Graphics > Advanced could be split into several sections (this is a bigger question), there may be other tall tabs in the future. Ideally, no size adjustment should be required but, until Dolphin gets there, the adjustment should not be of 90% of the screen (no desktop environment does this for new windows, probably for a good reason). Using 90% of the screen has been a bit irritating to me, as it leaves the relevant information towards the top of the screen, far away from my mouse pointer. |
|
Would 80% (instead of 90% of the screen dimensions) be a sensible compromise? |
The maximum size for the initial size in dialogs has been reduced from 90% to 75% of the screen dimensions for screen resolutions greater than FullHD (
1920x1080).Rationale: Almost no dialog in the application requires such a tall window resolution (an exception is the Graphics > Advanced pane in the Settings dialog). The reduced size prevents dialogs from appearing close to the edges of the screen, which was opinionatedly not too elegant.
Devices with smaller screen resolutions (generally handheld devices) will continue to use a 90% factor of the screen dimensions.