-
Notifications
You must be signed in to change notification settings - Fork 693
Remove commas between endpoints in grid #6359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The commas between endpoints are redundant as the underline of the anchor visually separates multiple entries. The comma visually collides with the underline, and looks a bit strange when there's only one item and the rest in overflow. Subjective, but I think it looks a little sharper like this.
This won't be true for tcp endpoints. They're plain text. However, maybe the space can be the delimiter. That shouldn't be a situation where an endpoint contains spaces. |
@DamianEdwards @davidfowl @leslierichardson95 Opinions either way? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
True, some URLs won't be hyperlinked or underlined, but the space should still be clear. |
Yeah I like this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that space is an acceptable delimiter here
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@adamint the test failure here seems related to health checks. Did we commit something that breaks tests?
|
Description
The commas between endpoints are redundant as the underline of the anchor visually separates multiple entries. The comma visually collides with the underline, and looks a bit strange when there's only one item and the rest in overflow.
Subjective, but I think it looks a little sharper like this.
Before
After
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow