Skip to content

catch json error #9369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged

catch json error #9369

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b00f238
catch json error
danmoseley May 16, 2025
f2fefb3
spc
danmoseley May 16, 2025
4630a04
'using
danmoseley May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 29 additions & 21 deletions src/Aspire.Cli/DotNetCliRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,34 +659,42 @@ public async Task<int> AddPackageAsync(FileInfo projectFilePath, string packageN
}

var foundPackages = new List<NuGetPackage>();
var document = JsonDocument.Parse(stdout);

var searchResultsArray = document.RootElement.GetProperty("searchResult");

foreach (var sourceResult in searchResultsArray.EnumerateArray())
try
{
var source = sourceResult.GetProperty("sourceName").GetString();
var sourcePackagesArray = sourceResult.GetProperty("packages");

foreach (var packageResult in sourcePackagesArray.EnumerateArray())
{
var id = packageResult.GetProperty("id").GetString();
using var document = JsonDocument.Parse(stdout);

// var version = prerelease switch {
// true => packageResult.GetProperty("version").GetString(),
// false => packageResult.GetProperty("latestVersion").GetString()
// };
var searchResultsArray = document.RootElement.GetProperty("searchResult");

var version = packageResult.GetProperty("latestVersion").GetString();
foreach (var sourceResult in searchResultsArray.EnumerateArray())
{
var source = sourceResult.GetProperty("sourceName").GetString();
var sourcePackagesArray = sourceResult.GetProperty("packages");

foundPackages.Add(new NuGetPackage
foreach (var packageResult in sourcePackagesArray.EnumerateArray())
{
Id = id!,
Version = version!,
Source = source!
});
var id = packageResult.GetProperty("id").GetString();

// var version = prerelease switch {
// true => packageResult.GetProperty("version").GetString(),
// false => packageResult.GetProperty("latestVersion").GetString()
// };

var version = packageResult.GetProperty("latestVersion").GetString();

foundPackages.Add(new NuGetPackage
{
Id = id!,
Version = version!,
Source = source!
});
}
}
}
catch (JsonException ex)
{
logger.LogError($"Failed to read JSON returned by the package search. {ex.Message}");
return (ExitCodeConstants.FailedToAddPackage, null);
}

return (result, foundPackages.ToArray());
}
Expand Down