Skip to content

System.CommandLine: add notes based on Threat Model review #48184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

System.CommandLine: add notes based on Threat Model review #48184

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad0bceb
add notes based on Threat Model review
adamsitnik Aug 29, 2025
2755b5c
Apply suggestions from code review
adamsitnik Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/standard/commandline/how-to-configure-the-parser.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ They are exposed by the <xref:System.CommandLine.ParseResult.Configuration?displ

[Response files](syntax.md#response-files) are enabled by default, but you can disable them by setting the <xref:System.CommandLine.ParserConfiguration.ResponseFileTokenReplacer> property to `null`. You can also provide a custom implementation to customize how response files are processed.

Response file can contain other response file names, hence parsing may include opening other files. The library expects that all response files were generated and stored by trust worthy agent(s).

## InvocationConfiguration

### Standard output and error
Expand Down
2 changes: 2 additions & 0 deletions docs/standard/commandline/syntax.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ A token can contain spaces if it's enclosed in quotation marks (`"`). Here's an
dotnet tool search "ef migrations add"
```

The symbol hierarchy (commands, options, arguments) is considered to be trusted input, the token values are not.

## Commands

A *command* in command-line input is a token that specifies an action or defines a group of related actions. For example:
Expand Down
Loading