Skip to content

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Sep 8, 2025

Summary

  • Fix the linked issue, which added the \p{Mn} to the class description. I also reordered it to match the table.
  • Migrated C# code.
  • Migrated VB code.
  • Fixed older article migration problems (double spaces at the end of the line, bad indentation, etc)
  • Upgraded acro score from 71 to 78. (tough to go further without a complete rewrite as acro is really sensitive to the way regex is talked about)

Fixes #43928

Important

Snippets don't actually fail. Removing the old snippets but then discovering that one snippet is used by a different article, causes the build to fail because it think's we're touching the bad area, when we're not. Normally you would remove all snippets from the folder but I don't want to touch the other article unless we move all the snippets in that article, which is out of scope.


Internal previews

📄 File 🔗 Preview link
docs/standard/base-types/character-classes-in-regular-expressions.md Character classes in regular expressions

@adegeo adegeo marked this pull request as ready for review September 8, 2025 19:45
@adegeo adegeo requested review from BillWagner, a team and IEvangelist as code owners September 8, 2025 19:45
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @adegeo

Let's :shipit:

@adegeo adegeo merged commit 53f26c1 into main Sep 9, 2025
9 of 10 checks passed
@adegeo adegeo deleted the adegeo/43928/regex branch September 9, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regex \W inconsistency
3 participants