Support collecting GC collect only trace using a simplified profile #6348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktork
reviewed
Mar 28, 2024
src/Microsoft.Diagnostics.Monitoring.WebApi/Utilities/TraceUtilities.cs
Outdated
Show resolved
Hide resolved
wiktork
reviewed
Mar 28, 2024
wiktork
reviewed
Mar 28, 2024
src/Microsoft.Diagnostics.Monitoring.WebApi/Controllers/DiagController.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Mar 29, 2024
src/Microsoft.Diagnostics.Monitoring.WebApi/Models/TraceProfile.cs
Outdated
Show resolved
Hide resolved
cshung
force-pushed
the
public/gc-collect-profile
branch
from
9eb91d7 to
f29045c
Compare
schmittjoseph
added
the
update-release-notes
|
Could you add the new TraceProfile enum value to https://github.com/dotnet/dotnet-monitor/blob/main/src/Tests/Microsoft.Diagnostics.Monitoring.Tool.UnitTestCommon/ActionTestsHelper.cs#L60 so that the |
cshung
force-pushed
the
public/gc-collect-profile
branch
from
f29045c to
d6ab130
Compare
jander-msft
approved these changes
Apr 9, 2024
jwreford99
added a commit
to jwreford99/dotnet-monitor
that referenced
this pull request
Jul 18, 2024
Support for this was added in dotnet#6348, but the documentation was never updated
wiktork
pushed a commit
to jwreford99/dotnet-monitor
that referenced
this pull request
Jul 25, 2024
Support for this was added in dotnet#6348, but the documentation was never updated
schmittjoseph
pushed a commit
that referenced
this pull request
Jul 26, 2024
Support for this was added in #6348, but the documentation was never updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4605
To make collecting gc-collect only traces easier with dotnet-monitor. I have made this change so that you can have a gc profile.
Ideally, the classGcCollectConfigurationshould be part ofMicrosoft.Diagnostics.Monitoring.EventPipe.dll. it will be after dotnet/diagnostics#4568Release Notes Entry
Add
GcCollecttrace profile for collecting lightweight GC collection events, same as thegc-collectprofile in thedotnet-tracetool.