Add MVID and MethodToken To Parameters
#7974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmittjoseph
added
experimental-feature
...gnostics.Monitoring.StartupHook/ParameterCapturing/Eventing/ParameterCapturingEventSource.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.StartupHook/ParameterCapturing/MethodSignature.cs
Show resolved
Hide resolved
|
Let's also add/update a function test for this -- |
wiktork
reviewed
Feb 28, 2025
wiktork
previously approved these changes
Mar 3, 2025
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/ParameterCapturingTests.cs
Outdated
Show resolved
Hide resolved
...icrosoft.Diagnostics.Monitoring.WebApi/ParameterCapturing/CapturedParametersTextFormatter.cs
Outdated
Show resolved
Hide resolved
schmittjoseph
previously approved these changes
Mar 4, 2025
schmittjoseph
previously approved these changes
Mar 5, 2025
jander-msft
reviewed
Mar 5, 2025
src/Microsoft.Diagnostics.Monitoring.StartupHook/ParameterCapturing/MethodSignature.cs
Show resolved
Hide resolved
schmittjoseph
previously approved these changes
Mar 5, 2025
…dotnet-monitor into kkeirstead/paramMVID
schmittjoseph
approved these changes
Mar 6, 2025
schmittjoseph
added a commit
that referenced
this pull request
Apr 1, 2025
* Update dependencies from https://github.com/dotnet/diagnostics build 20250305.1 (#7993) [main] Update dependencies from dotnet/diagnostics * generate release notes (#7996) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update releaseNotes.v9.1.0-preview.1.md (#7997) * Add `MVID` and `MethodToken` To Parameters (#7974) * Starting to pipe through method info * In theory this is flowing the data through - untested. * Cleanup * PR Feedback * Updated test to check for mvid and methodtoken * Switched to checking against flexible values in test * Using real values for method token and mvid in test * Reverted line adding output to plain text * Update definitions.md * Update parameters.md * Adding comments * Add `Capabilities` to `/info` Route (#7977) * Register v9.1.0-preview.1.25155.2 release information (#7999) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * update release information (#8001) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20250311.4 (#8006) [main] Update dependencies from dotnet/arcade * Update dependencies from https://github.com/dotnet/arcade build 20250314.2 (#8009) [main] Update dependencies from dotnet/arcade * Update dependencies from https://github.com/dotnet/command-line-api build 20250317.1 (#8014) [main] Update dependencies from dotnet/command-line-api * Bump streetsidesoftware/cspell-action from 6.10.0 to 6.10.1 (#7998) Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 6.10.0 to 6.10.1. - [Release notes](https://github.com/streetsidesoftware/cspell-action/releases) - [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md) - [Commits](streetsidesoftware/cspell-action@ef95dc4...8485bb4) --- updated-dependencies: - dependency-name: streetsidesoftware/cspell-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [main] Bump Microsoft.NETCore.DotNetHost (#8000) Bumps the runtime-dependencies group in /eng/dependabot/net8.0 with 1 update: [Microsoft.NETCore.DotNetHost](https://github.com/dotnet/runtime). Updates `Microsoft.NETCore.DotNetHost` from 8.0.13 to 8.0.14 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](https://github.com/dotnet/runtime/commits) --- updated-dependencies: - dependency-name: Microsoft.NETCore.DotNetHost dependency-type: direct:production update-type: version-update:semver-patch dependency-group: runtime-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Learning Paths (#7976) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/command-line-api build 20250318.1 (#8016) [main] Update dependencies from dotnet/command-line-api * Add managed entry point to process info and collection rule filters (#7984) * Bump actions/upload-artifact from 4.6.1 to 4.6.2 (#8018) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.1 to 4.6.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@4cec3d8...ea165f8) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/command-line-api build 20250320.1 (#8019) [main] Update dependencies from dotnet/command-line-api * Use openapi generator (#8008) * Move deployment samples from Markdown files to ready-to-deploy sample files (#7926) * Code flow updates (#8020) * Limit managed entry point assembly tests to net8.0 and higher (#8022) * Update DefaultProcessConfigurationTests for managed entry point assembly (#8023) * Add stub release build (#8033) * Add stub release build * PR feedback * Bump gaurav-nelson/github-action-markdown-link-check (#8037) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.16 to 1.0.17. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1b916f2...3c3b66f) --- updated-dependencies: - dependency-name: gaurav-nelson/github-action-markdown-link-check dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Wiktor Kopec <[email protected]> Co-authored-by: kkeirstead <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justin Anderson <[email protected]> Co-authored-by: Sven Boemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
MVIDandMethodTokento Parameter Capture output.Release Notes Entry
Added
ModuleVersionIdandMethodTokenFields to Parameter Capture Output