MigrationsInfrastructureTestBase contains SQL Server-specific code

[roji]

See https://github.com/dotnet/efcore/pull/32788/files#r1485597530. We should either introduce provider-specific quoting (like for raw SQL in query tests) or move the problematic SQL to the SQL Server-specific subclass.

[RupenAnjaria]

@roji are you suggesting to move the Migration6 and Migration7 or should not have "GO" (just like Migration5)?
To me, the variable "TestValue" is just seems some test value and isn't for execution, so whether it's specific to SQL or not should not matter. (I could be completely wrong).

However, should I try with following change:

public const string TestValue = """

Value With

Empty Lines
""";

We can also add check like Migration3 and Migration4:

if (ActiveProvider == "Microsoft.EntityFrameworkCore.SqlServer")

Please suggest.

[roji]

@RupenAnjaria the main comment refers to the unquoted table name (Table1). The second comment about GO indeed refers to a string, but it's not some arbitrary string value - the test is specifically there to test SQL Server-specific parsing etc. It doesn't have to move, but it is a SQL Server-specific case/test that's in base.

[ajcvickers]

@roji How blocking is this for you?

[roji]

But really blocking - just skipping those tests for now... Just something to clean up at some point