[release/9.0] Don't execute empty batches #34870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Oct 10, 2024
AndriySvyryd
force-pushed
the
Issue34841
branch
from
bea4f56 to
b3cbdac
Compare
AndriySvyryd
force-pushed
the
Issue33337
branch
from
73819e4 to
fb27728
Compare
AndriySvyryd
force-pushed
the
Issue34841
branch
from
b3cbdac to
efa76b3
Compare
AndriySvyryd
force-pushed
the
Issue33337
branch
from
fb27728 to
3bea4d9
Compare
AndriySvyryd
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33337
Description
In EF Core 8.0.3 we fixed an issue where empty lines were incorrectly removed from literals in migration scripts. However, this caused some operations to contain only empty lines.
Customer impact
Exception thrown when applying a migration in the above scenario, as it's considered an error to execute an empty operation.
How found
Multiple customer reports since 8.0.3
Regression
Yes, from 8.0.2. Introduced in #32788
Testing
Tests added
Risk
Low.