-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[release/9.0] Don't suppress transactions when creating the history repository #35266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
approved these changes
Dec 4, 2024
This was referenced Jul 22, 2025
This was referenced Sep 17, 2025
Merged
Closed
Open
Bump Microsoft.EntityFrameworkCore.SqlServer from 9.0.0 to 9.0.9
pabloeferreyra/CuentasCorrientes#53
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35127
Addresses dotnet/docs-aspire#2151
Description
When applying migrations the first time to a database EF creates a history table to keep track of the applied migrations.
In EF 9.0 this action was made idempotent to mitigate issues from concurrent applications as for some providers this is done before acquiring an exclusive migrations lock.
However, it was erroneously suppressing transactions.
Customer impact
When calling
Migrate
in an explicit transaction an exception is thrown. This is common in Aspire scenarios. The workaround is to remove the explicit transaction.How found
Multiple customer reports on 9 (5 so far).
Regression
Yes, from 8.
Testing
Tests added.
Risk
Low.