-
Notifications
You must be signed in to change notification settings - Fork 829
[AI Evaluation] Add versioning to reporting and caching #6070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/ScenarioRunResult.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 11, 2025
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/DistributedCachingChatClient.cs
Show resolved
Hide resolved
stephentoub
reviewed
Mar 11, 2025
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/DistributedCachingChatClient.cs
Outdated
Show resolved
Hide resolved
…edCachingChatClient.cs
shyamnamboodiripad
approved these changes
Mar 11, 2025
@dotnet/dotnet-extensions-ai This change is ready to merge if you approve. |
RussKie
reviewed
Mar 11, 2025
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/ScenarioRunResult.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Mar 11, 2025
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/Defaults.cs
Outdated
Show resolved
Hide resolved
…arp/ScenarioRunResult.cs Co-authored-by: Igor Velikorossov <[email protected]>
…arp/Defaults.cs Co-authored-by: Igor Velikorossov <[email protected]>
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/ScenarioRunResult.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/DistributedCachingChatClient.cs
Show resolved
Hide resolved
stephentoub
reviewed
Mar 12, 2025
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/Defaults.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 12, 2025
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/ScenarioRunResult.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 12, 2025
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/ScenarioRunResult.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/ScenarioRunResult.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/ScenarioRunResult.cs
Outdated
Show resolved
Hide resolved
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/Defaults.cs
Outdated
Show resolved
Hide resolved
Updated based on your feedback @shyamnamboodiripad @stephentoub |
stephentoub
reviewed
Mar 13, 2025
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/ScenarioRunResult.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 13, 2025
test/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting.Tests/ScenarioRunResultTests.cs
Show resolved
Hide resolved
stephentoub
reviewed
Mar 13, 2025
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/ScenarioRunResult.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Mar 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are basically independent escape mechanisms to handle future changes in formats.
ReportFormatVersion
- Will record which version of the format was used to persist the scenario run, as well as exposing which version the current library will write. This should allow us to convert/adapt to reporting format changes in the future if needed.CacheVersion
- Will change all the caching keys causing the existing cache entries to be no longer valid. @stephentoub @SteveSandersonMSHopefully neither of these will ever be needed.
Microsoft Reviewers: Open in CodeFlow