Expose some Microsoft.Extensions.Http.Diagnostics API #6747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR exposes Microsoft.Extensions.Http.Diagnostics API classes by converting internal interfaces to public abstract base classes. The changes support proposal #6737 to make HTTP diagnostics functionality available for external consumption.
- Convert internal interface-based implementations to public abstract base classes
- Replace interface references with concrete class types throughout the codebase
- Add experimental API attributes to indicate preview status
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.Telemetry/Http/ | Convert IHttpRouteParser/IHttpRouteFormatter interfaces to abstract base classes with public APIs |
| src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/ | Convert IDownstreamDependencyMetadataManager to abstract base class and update registrations |
| test/ | Update test files to use concrete types instead of interfaces |
| src/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/ | Update middleware to use concrete parser/formatter types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
test/Libraries/Microsoft.Extensions.Http.Diagnostics.Tests/Logging/HttpClientLoggerTest.cs
Show resolved
Hide resolved
| { | ||
| return _routeTemplateSegmentsCache.GetOrAdd(httpRoute, httpRoute => | ||
| return _routeTemplateSegmentsCache.GetOrAdd(httpRoute, _ => |
There was a problem hiding this comment.
Suggested change
| return _routeTemplateSegmentsCache.GetOrAdd(httpRoute, _ => | |
| return _routeTemplateSegmentsCache.GetOrAdd(httpRoute, httpRoute => |
If we pass httpRoute as a parameter rather than getting it from the closure we'll save some bytes, won't we?
iliar-turdushev
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to back up the proposal #6737
Microsoft Reviewers: Open in CodeFlow