Fix Ix.NET build break on Ubuntu 24 #2209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this runtime no longer works on the hosted agents. (This means we currently have no way to test netcoreapp2.1.)
Also, fix tests that suddenly no longer compile. I think this may be due to the compiler fixing what was technically a bug that meant that this sort of code
var res = new[] { 1, 2, 3, 4, 5, 6, 7, 8 };
Assert.True(res.SequenceEqual(await c.ToArrayAsync()));
no longer works because it performs the implicit conversion of `res` from `int[]` to `ReadOnlySpan<int>` before executing the `await`.
The Ubuntu-24 agents dropped support for mono and MSBuild. Turns out these tests were relying on mono to test the .NET FX builds! Also remove .NET Core 3.1 install step in build pipeline
HowardvanRooijen
approved these changes
Jun 10, 2025
idg10
added a commit
that referenced
this pull request
Jun 10, 2025
* Remove netcoreapp3.1 from tests. It looks like this runtime no longer works on the hosted agents. (This means we currently have no way to test netcoreapp2.1.) * Fix tests that suddenly no longer compile. I think this may be due to the compiler fixing what was technically a bug * Put build agent back to Windows. The Ubuntu-24 agents dropped support for mono and MSBuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure DevOps Hosted Build Agents now run Ubuntu 24. One consequence is that mono is no longer available on the build agents—it is not supported on Ubuntu 24.
The Ix pipeline had been running on Ubuntu, which meant that the unit tests targetting .NET FX relied on mono. We can't do that any more. This PR changes the build agent back to Windows, so we can continue to test on .NET FX.
Also, the tests were crashing on .NET Core 3.1. That runtime has been out of support for a long time, but we had continued to use it as it was the only way to test our
netstandard2.1support. I've had to disable this, so for now we don't execute tests against thenetstandard2.1builds. It's possible that there's no longer any reason to offer this target, so we might need to remove that in the future.There's one more fix in this PR: the C# compiler seems to have tightened up its handling of left-to-right execution order in SDK 9.0.300, with the result that the project no longer built in the current version of Visual Studio. I think this is technically fixing a bug in the compiler, but it meant that some cases where we do code of this kind:
now fail because of a combination of factors:
SequenceEqualsused to resolve to anIEnumerable<T>extension method, and still does on .NET FX, but on .NET it now resolves to an extension method onReadOnlySpan<T>instead.ReadOnlySpan<T>now happens before theawait(which apparently didn't happen in older compilers) which means we're now asking the compiler to make a span survive across anawait, which is not supportedSo I had to change some tests to get it building again.