Fix shutdown on foreign thread #100817
Merged
Fix shutdown on foreign thread #100817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a foreign thread running in .NET process is killed or crashes due to some hardware exception, the .NET code that performs shutdown gets called and incorrectly expects the thread to be a thread that's registered with the runtime. It calls GetThread on it and then calls a method on the thread. That leads to an assert in debug builds and crash in release ones. The function that is called is not needed for foreign threads though, so the fix is to skip calling it if the GetThreadNULLOk returns NULL (that means the thread is foreign and never registered with the runtime).
AaronRobinsonMSFT
approved these changes
Apr 9, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
When a foreign thread running in .NET process is killed or crashes due to some hardware exception, the .NET code that performs shutdown gets called and incorrectly expects the thread to be a thread that's registered with the runtime. It calls GetThread on it and then calls a method on the thread. That leads to an assert in debug builds and crash in release ones. The function that is called is not needed for foreign threads though, so the fix is to skip calling it if the GetThreadNULLOk returns NULL (that means the thread is foreign and never registered with the runtime).
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/15403960690 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a foreign thread running in .NET process is killed or crashes due to some hardware exception, the .NET code that performs shutdown gets called and incorrectly expects the thread to be a thread that's registered with the runtime. It calls
GetThreadon it and then calls a method on the thread. That leads to an assert in debug builds and crash in release ones.The function that is called is not needed for foreign threads though, so the fix is to skip calling it if the
GetThreadNULLOkreturns NULL (that means the thread is foreign and never registered with the runtime).Close #95419