-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[wasm][coreclr] Get further in the runtime initialization #116383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][coreclr] Get further in the runtime initialization #116383
Conversation
Add corewasmhost binary to test runtime initialization Fix linking of the host binary with coreclr and interpreter Allow calling interpreter with arguments and handle return value Use fake precode stubs to pass the precode type and method desc Make alternate signal stack calls no-op on wasm Implement CallDescrWorkerInternal on wasm Fix PE image loading without RTR on wasm Do not use unsupported syscalls
c49f135
to
b32ad25
Compare
Co-authored-by: Adeel Mujahid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearing my requested changes
/ba-g the WasmBuiltTest timeout is also happening on main https://github.com/dotnet/runtime/runs/46613148591 |
Add corewasmhost binary to test runtime initialization
Fix linking of the host binary with coreclr and interpreter
Allow calling interpreter with arguments and handle return value
Use fake precode stubs to pass the precode type and method desc
Make alternate signal stack calls no-op on wasm
Implement CallDescrWorkerInternal on wasm
Use flat PE image loading on wasm
Do not use unsupported syscalls