Skip to content

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Aug 26, 2025

Link issues

fixes #6682

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Clarify the interdependent behavior of the EditDialogIsDraggable and EditDialogShowMaximizeButton parameters and update the sample usage to disable the maximize button for draggable dialogs.

Enhancements:

  • Clarify in code comments that EditDialogIsDraggable only takes effect when EditDialogShowMaximizeButton is false and vice versa

Documentation:

  • Update TablesEdit sample to set EditDialogShowMaximizeButton="false" when demonstrating a draggable edit dialog

@Copilot Copilot AI review requested due to automatic review settings August 26, 2025 07:34
@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Aug 26, 2025
@bb-auto bb-auto bot added this to the 9.9.0 milestone Aug 26, 2025
Copy link
Contributor

sourcery-ai bot commented Aug 26, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Table component’s XML documentation to clarify how the EditDialogIsDraggable and EditDialogShowMaximizeButton parameters interact and adjusts the sample page to demonstrate disabling the maximize button to enable dragging.

File-Level Changes

Change Details Files
Clarify interaction between EditDialogIsDraggable and EditDialogShowMaximizeButton in XML docs
  • Update EditDialogIsDraggable summary to note it only applies when maximize button is disabled
  • Update EditDialogShowMaximizeButton summary to note it disables draggable behavior when enabled
src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs
Update sample configuration to demonstrate draggable dialog usage
  • Add EditDialogShowMaximizeButton="false" to sample Table in TablesEdit.razor
src/BootstrapBlazor.Server/Components/Samples/Table/TablesEdit.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#6682 Update documentation for the EditDialogIsDraggable parameter to clarify its behavior and relationship with EditDialogShowMaximizeButton.
#6682 Add sample code demonstrating the use of EditDialogIsDraggable, including its interaction with EditDialogShowMaximizeButton.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates documentation for the Table component's EditDialogIsDraggable property to clarify its interaction with EditDialogShowMaximizeButton. The documentation now explicitly states that EditDialogIsDraggable only takes effect when EditDialogShowMaximizeButton is false.

  • Updated XML documentation comments to clarify the relationship between EditDialogIsDraggable and EditDialogShowMaximizeButton properties
  • Added a demo example showing EditDialogIsDraggable in action with EditDialogShowMaximizeButton set to false

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Table.razor.Toolbar.cs Updated XML documentation to clarify property interaction behavior
TablesEdit.razor Added demo configuration showing EditDialogIsDraggable usage with EditDialogShowMaximizeButton disabled

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit 481b744 into main Aug 26, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the doc-table branch August 26, 2025 07:37
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2136312) to head (cd686ba).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6683   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31698     31698           
  Branches      4462      4462           
=========================================
  Hits         31698     31698           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc(Table): update EditDialogIsDraggable documentation
1 participant