-
-
Notifications
You must be signed in to change notification settings - Fork 359
doc(Table): update EditDialogIsDraggable documentation #6683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Table component’s XML documentation to clarify how the EditDialogIsDraggable and EditDialogShowMaximizeButton parameters interact and adjusts the sample page to demonstrate disabling the maximize button to enable dragging. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates documentation for the Table component's EditDialogIsDraggable property to clarify its interaction with EditDialogShowMaximizeButton. The documentation now explicitly states that EditDialogIsDraggable only takes effect when EditDialogShowMaximizeButton is false.
- Updated XML documentation comments to clarify the relationship between EditDialogIsDraggable and EditDialogShowMaximizeButton properties
- Added a demo example showing EditDialogIsDraggable in action with EditDialogShowMaximizeButton set to false
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
Table.razor.Toolbar.cs | Updated XML documentation to clarify property interaction behavior |
TablesEdit.razor | Added demo configuration showing EditDialogIsDraggable usage with EditDialogShowMaximizeButton disabled |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6683 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 739 739
Lines 31698 31698
Branches 4462 4462
=========================================
Hits 31698 31698
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6682
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Clarify the interdependent behavior of the EditDialogIsDraggable and EditDialogShowMaximizeButton parameters and update the sample usage to disable the maximize button for draggable dialogs.
Enhancements:
Documentation: