test(server): test transaction locked keys #1669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adiholden
commented
Aug 8, 2023
adiholden
commented
- Add test utility class that will add suspension to transaction execution.
- Add test for locked keys in transaction
1. add test utility class that will add suspension to transaction execution. 2. add test for locked keys in transaction Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
dranikpg
previously approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Great, I imagined it in a similar way.
Just as an idea: For other tests to use it it'd be convenient if the TransactionSuspension would itself start a fiber and loops, so you could do
auto lock_check = CheckWillBeLocked("key", ...) // starts fiber and lets go once locks are rightly acquired
Run(mycmd)
But as the only user (or not?) are cluster tests its all open for you to decide 🙂
chakaz
reviewed
Aug 9, 2023
src/server/test_utils.cc
Outdated
|
|
||
| void TransactionSuspension::Start() { | ||
| CommandId cid{"TEST", CO::WRITE | CO::GLOBAL_TRANS, -1, 0, 0, 0}; | ||
| transaction_.reset(new dfly::Transaction{&cid}); |
src/server/multi_test.cc
Outdated
Comment on lines
820
to
825
| for (int i = 0; i < 1000; ++i) { | ||
| if (service_->IsLocked(0, "key1") && service_->IsLocked(0, "key2")) { | ||
| break; | ||
| } | ||
| ThisFiber::SleepFor(1ms); | ||
| } |
There was a problem hiding this comment.
We use this hack in many places, maybe move ExpectConditionWithinTimeout to test_utils.h and use it here?
There was a problem hiding this comment.
This has the advantage of failing the test in the case of a timeout, because right now even if TransactionSuspension does nothing, the test will still pass
Signed-off-by: adi_holden <[email protected]>
chakaz
previously approved these changes
Aug 9, 2023
Signed-off-by: adi_holden <[email protected]>
chakaz
previously approved these changes
Aug 9, 2023
Signed-off-by: adi_holden <[email protected]>
romange
approved these changes
Aug 9, 2023
chakaz
approved these changes
Aug 9, 2023
Comment on lines
+106
to
+108
| ./dragonfly_test | ||
| ./multi_test --multi_exec_mode=1 | ||
| ./multi_test --multi_exec_mode=3 |
There was a problem hiding this comment.
Consider moving these to the daily instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.