fix: add proper printing of sha256 passwords

[kostasrim]

1. Properly print sha256 passwords by converting hex values to characters

[dranikpg]

We had some utility like this somewhere 🤷

[kostasrim]

We had some utility like this somewhere

I will take a look before I merge, last time I checked I couldn't find anything

[kostasrim]

I will take a look before I merge, last time I checked I couldn't find anything

Couldn't find anything, I imagine it would use isdigit (which I used to grep it) but nothing relevant came up).

I will move this at some point to a utility header, but it's a non priority for now

[romange]

absl::CHexEscape

…

On Thu, Aug 24, 2023 at 9:59 AM Kostas Kyrimis ***@***.***> wrote: I will take a look before I merge, last time I checked I couldn't find anything Couldn't find anything, I imagine it would use isdigit (which I used to grep it) but nothing relevant came up). I will move this at some point to a utility header, but it's a non priority for now — Reply to this email directly, view it on GitHub <#1728 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4BFCBDMMXW2UDRMESZJZLXW33VFANCNFSM6AAAAAA33VEHZA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Roman Gershman CTO --- *www.dragonflydb.io <http://www.dragonflydb.io>*

[dranikpg]

It's not escaping. The SHA is essentially a uint8_t[] (just stored in a string) and he wants to print it compactly, so his code is actually

string out;
for (char c: password)
  absl::StrAppend(&out, absl::Hex(c));

to get smth like this

d14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f

[kostasrim]

@dranikpg

True, but not every character is a hex so you still need the conditional. Although it can be written in a more expressive fashion:

instead of
isdigit(c) ? result.push_back(c) : absl::StrAppend(&result, absl::Hex(c));

absl::StrAppend(&result, isdigit(c) : c : absl::Hex(c));

And I like the second more, so I will make this change :D

[kostasrim]

Uh and you can't because Incompatible operand types :(

[royjacobson]

There's absl::BytesToHexString in absl/strings/escaping.h

[dranikpg]

1. What about the leading digit? [1, 1] should be 0101

I thinks its better to use what Roy found 😝

// BytesToHexString()
//
// Converts binary data into an ASCII text string, returning a string of size
// `2*from.size()`.
std::string BytesToHexString(absl::string_view from);

[kostasrim]

100%

[dranikpg]

I don't understand 😄 bytes to hex string returns a string of length 30 (twice the size), why do you need only half of it?

[kostasrim]

Because I want to print up to 15 characters :D

[dranikpg]

Okay I'm just gonna trust you on this one 🤣

The base branch was changed.