Skip to content

refactor: block list refactoring #2580 #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024
Merged

refactor: block list refactoring #2580 #2732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/core/search/block_list.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ template <typename C> typename BlockList<C>::BlockIt BlockList<C>::FindBlock(Doc
if (it != blocks_.begin())
--it;

DCHECK(it == blocks_.begin() || it->Size() > 0);
DCHECK(it == blocks_.begin() || it == blocks_.begin() || it->Size() * 2 >= block_size_);
DCHECK(it == blocks_.begin() || it->Size() * 2 >= block_size_);
DCHECK(it == blocks_.end() || it->Size() <= 2 * block_size_);
return it;
}
Expand Down
3 changes: 3 additions & 0 deletions src/core/search/block_list.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,7 @@ struct SortedVector {
PMR_NS::vector<DocId> entries_;
};

extern template class BlockList<CompressedSortedSet>;
extern template class BlockList<SortedVector>;

} // namespace dfly::search