Skip to content

chore: remove duplicate code from dash and simplify #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2024
Merged

chore: remove duplicate code from dash and simplify #2765

merged 1 commit into from
Mar 29, 2024

Conversation

kostasrim
Copy link
Contributor

  • rename all Policy members for consistency
  • remove duplicate code

@kostasrim kostasrim self-assigned this Mar 22, 2024
@dranikpg
Copy link
Contributor

Yay my favourite refactoring PRs 🥳🥳

romange
romange reviewed Mar 24, 2024
View reviewed changes
src/core/dash_internal.h

// calls for each busy slot: cb(iterator, probe)
template <typename Cb> void ForEachSlot(Cb&& cb) const {
template <typename This, typename Cb> void ForEachSlotImpl(This obj, Cb&& cb) const {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. curious, why you added This template?
  2. You also use this at line 345-346. is it intended?

romange
romange reviewed Mar 24, 2024
View reviewed changes
src/core/dash_internal.h
probe_mask >>= 1;
}
// calls for each busy slot: cb(iterator, probe)
template <typename Cb> void ForEachSlot(Cb&& cb) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand now

romange
romange reviewed Mar 24, 2024
View reviewed changes
src/core/dash_internal.h
bid_res[cnt++] = nid;
};

if (CheckIfMovesToOther(true, nid, after_next)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a functional change?

romange
romange reviewed Mar 24, 2024
View reviewed changes
src/core/dash_internal.h
};

if (target.GetVersion() < ver_threshold) {
auto do_fun = [&result, &result_bid, fp_hash, find_stash](auto& target, auto target_bid,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a functional change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not really, same for your other comments. I probably changed something during refactoring, will fix it. This PR should have no functional changes.

romange
romange reviewed Mar 24, 2024
View reviewed changes
src/core/dash_internal.h Outdated
res += bucket_[i].Size();
}
return res;
return std::accumulate(&bucket_[0], &bucket_[0] + kTotalBuckets, size_t(0),
Copy link
Collaborator

@romange romange Mar 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to ask you to revert this change :) just because std::acccumulate exists, it does not mean using it makes the code more readable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, accumulate has some "mental" reading overhead... Really anticipate ranges until it becomes view(bucket_, bucket_ + offset).map(size).sum()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO in this particular case I think accumulate is fine but I am more than happy to revert! @dranikpg I wanted to make the exact same comment but you got it first. Note that:

  1. ranges::accumulate is not part of c++20 unfortunately but I think it's available in c++23 as left_fold. And you can replace the custom lambda with a projection (similar to .map you wrote)
  2. boost::accumulate would suffice here as well

Generally, my main complain against STL algorithms (as with most of the world) is that you have to pass the range explicitly. I would personally opt in (as suggested in the past as well) to use one of the two libraries in our codebase and make our life a little easier with using those algorithms.

romange
romange reviewed Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for improving the code here!

@kostasrim kostasrim requested review from romange and dranikpg March 28, 2024 19:04
@kostasrim kostasrim merged commit 370f334 into main Mar 29, 2024
@kostasrim kostasrim deleted the dash_refactor branch March 29, 2024 09:14
szinn referenced this pull request in szinn/k8s-homelab Apr 3, 2024
@repo-jeeves
feat(container): update image docker.dragonflydb.io/dragonflydb/drago…
65bdaf8 
…nfly ( v1.15.1 → v1.16.0 ) (#3354)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[docker.dragonflydb.io/dragonflydb/dragonfly](https://togithub.com/dragonflydb/dragonfly)
| minor | `v1.15.1` -> `v1.16.0` |

---

### Release Notes

<details>
<summary>dragonflydb/dragonfly
(docker.dragonflydb.io/dragonflydb/dragonfly)</summary>

###
[`v1.16.0`](https://togithub.com/dragonflydb/dragonfly/releases/tag/v1.16.0)

[Compare
Source](https://togithub.com/dragonflydb/dragonfly/compare/v1.15.1...v1.16.0)

##### Dragonfly v1.16.0

Our spring release. We are getting closer to 2.0 with some very exciting
features ahead. Stay tuned!

Some prominent changes include:

- Improved memory accounting of client connections
([#&#8203;2710](https://togithub.com/dragonflydb/dragonfly/issues/2710)
[#&#8203;2755](https://togithub.com/dragonflydb/dragonfly/issues/2755)
and
[#&#8203;2692](https://togithub.com/dragonflydb/dragonfly/issues/2692) )
- FT.AGGREGATE call
([#&#8203;2413](https://togithub.com/dragonflydb/dragonfly/issues/2413))
- Properly handle and replicate Memcache flags
([#&#8203;2787](https://togithub.com/dragonflydb/dragonfly/issues/2787)
[#&#8203;2807](https://togithub.com/dragonflydb/dragonfly/issues/2807))
- Intoduce BF.AGGREGATE BD.(M)ADD and BF.(M)EXISTS methods
([#&#8203;2801](https://togithub.com/dragonflydb/dragonfly/issues/2801)).
Note, that it does not work with snapshots and replication yet.
- Dragonfly builds natively on MacOS. We would love some help with
extending the release pipeline to create a proper macos binary.
- Following the requests from the Edge developers community, we added a
basic HTTP API support! Try running Dragonfly with:
`--expose_http_api` flag and then call `curl -X POST -d '["ping"]'
localhost:6379/api`. We will follow up with more extensive docs later
this month.
- Lots of stability fixes, especially around Sidekiq and BullMQ
workloads.

##### What's Changed

- chore: make usan asan optional and enable them on CI by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2631](https://togithub.com/dragonflydb/dragonfly/pull/2631)
- fix: missing manual trigger for daily sanitizers by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2682](https://togithub.com/dragonflydb/dragonfly/pull/2682)
- bug(tiering): fix overflow in page offset calculation and wrong hash
offset calculation by [@&#8203;theyueli](https://togithub.com/theyueli)
in
[https://github.com/dragonflydb/dragonfly/pull/2683](https://togithub.com/dragonflydb/dragonfly/pull/2683)
- Chore: Fixed Docker Health Check by
[@&#8203;manojks1999](https://togithub.com/manojks1999) in
[https://github.com/dragonflydb/dragonfly/pull/2659](https://togithub.com/dragonflydb/dragonfly/pull/2659)
- chore: Increase disk space in the coverage runs by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2684](https://togithub.com/dragonflydb/dragonfly/pull/2684)
- fix(flushall): Decommit memory after releasing tables. by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2691](https://togithub.com/dragonflydb/dragonfly/pull/2691)
- feat(server): Account for serializer's temporary buffer size by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2689](https://togithub.com/dragonflydb/dragonfly/pull/2689)
- refactor: remove FULL-SYNC-CUT cmd
[#&#8203;2687](https://togithub.com/dragonflydb/dragonfly/issues/2687)
by [@&#8203;BorysTheDev](https://togithub.com/BorysTheDev) in
[https://github.com/dragonflydb/dragonfly/pull/2688](https://togithub.com/dragonflydb/dragonfly/pull/2688)
- chore: add malloc-based stats and decommit by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2692](https://togithub.com/dragonflydb/dragonfly/pull/2692)
- feat(cluster): automatic slot migration finalization
[#&#8203;2697](https://togithub.com/dragonflydb/dragonfly/issues/2697)
by [@&#8203;BorysTheDev](https://togithub.com/BorysTheDev) in
[https://github.com/dragonflydb/dragonfly/pull/2698](https://togithub.com/dragonflydb/dragonfly/pull/2698)
- Basic FT.AGGREGATE by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2413](https://togithub.com/dragonflydb/dragonfly/pull/2413)
- chore: little transaction cleanup by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2608](https://togithub.com/dragonflydb/dragonfly/pull/2608)
- fix(channel store): add acquire/release pair in fast update path by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2704](https://togithub.com/dragonflydb/dragonfly/pull/2704)
- chore: add ubuntu22 devcontainer by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2700](https://togithub.com/dragonflydb/dragonfly/pull/2700)
- feat(cluster): Add `--cluster_id` flag by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2695](https://togithub.com/dragonflydb/dragonfly/pull/2695)
- feat(server): Use mimalloc in SSL calls by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2710](https://togithub.com/dragonflydb/dragonfly/pull/2710)
- chore: Pull helio with new BlockingCounter by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2711](https://togithub.com/dragonflydb/dragonfly/pull/2711)
- chore(transaction): Simplify PollExecution by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2712](https://togithub.com/dragonflydb/dragonfly/pull/2712)
- chore(transaction): Don't call GetLocalMask from blocking controller
by [@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2715](https://togithub.com/dragonflydb/dragonfly/pull/2715)
- chore: improve compatibility of EXPIRE functions with Redis by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2696](https://togithub.com/dragonflydb/dragonfly/pull/2696)
- chore: disable flaky fuzzy migration test by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2716](https://togithub.com/dragonflydb/dragonfly/pull/2716)
- chore: update sanitizers workflow by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2686](https://togithub.com/dragonflydb/dragonfly/pull/2686)
- chore: Use c-ares for resolving hosts in `ProtocolClient` by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2719](https://togithub.com/dragonflydb/dragonfly/pull/2719)
- Remove check-fail in ExpireIfNeeded and introduce DFLY LOAD by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2699](https://togithub.com/dragonflydb/dragonfly/pull/2699)
- chore: Record cmd stat from invoke by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2720](https://togithub.com/dragonflydb/dragonfly/pull/2720)
- fix(transaction): nullptr access on non transactional commands by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2724](https://togithub.com/dragonflydb/dragonfly/pull/2724)
- fix(BgSave): async from sync by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2702](https://togithub.com/dragonflydb/dragonfly/pull/2702)
- chore: remove core/fibers by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2723](https://togithub.com/dragonflydb/dragonfly/pull/2723)
- fix(transaction): Replace with armed sync point by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2708](https://togithub.com/dragonflydb/dragonfly/pull/2708)
- feat(json): Deserialize ReJSON format by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2725](https://togithub.com/dragonflydb/dragonfly/pull/2725)
- feat: add flag masteruser by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2693](https://togithub.com/dragonflydb/dragonfly/pull/2693)
- refactor: block list refactoring
[#&#8203;2580](https://togithub.com/dragonflydb/dragonfly/issues/2580)
by [@&#8203;BorysTheDev](https://togithub.com/BorysTheDev) in
[https://github.com/dragonflydb/dragonfly/pull/2732](https://togithub.com/dragonflydb/dragonfly/pull/2732)
- chore: fix DeduceExecMode by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2733](https://togithub.com/dragonflydb/dragonfly/pull/2733)
- fix(cluster): Reply with correct `\n` / `\r\n` from `CLUSTER` sub cmd
by [@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2731](https://togithub.com/dragonflydb/dragonfly/pull/2731)
- chore: Introduce fiber stack allocator by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2730](https://togithub.com/dragonflydb/dragonfly/pull/2730)
- fix(cluster): Save replica ID per replica by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2735](https://togithub.com/dragonflydb/dragonfly/pull/2735)
- fix(ssl): Proper cleanup by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2742](https://togithub.com/dragonflydb/dragonfly/pull/2742)
- chore: add skeleton files for flat_dfs code by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2738](https://togithub.com/dragonflydb/dragonfly/pull/2738)
- chore: better error reporting when connecting to tls with plain socket
by [@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2740](https://togithub.com/dragonflydb/dragonfly/pull/2740)
- chore: Support json paths without root selector by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2747](https://togithub.com/dragonflydb/dragonfly/pull/2747)
- chore: journal cleanup by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2749](https://togithub.com/dragonflydb/dragonfly/pull/2749)
- refactor: remove start-slot-migration cmd
[#&#8203;2727](https://togithub.com/dragonflydb/dragonfly/issues/2727)
by [@&#8203;BorysTheDev](https://togithub.com/BorysTheDev) in
[https://github.com/dragonflydb/dragonfly/pull/2728](https://togithub.com/dragonflydb/dragonfly/pull/2728)
- feat(server): Add TLS usage to /metrics and `INFO MEMORY` by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2755](https://togithub.com/dragonflydb/dragonfly/pull/2755)
- chore: preparations for adding flat json support by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2752](https://togithub.com/dragonflydb/dragonfly/pull/2752)
- chore(transaction): Introduce RunCallback by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2760](https://togithub.com/dragonflydb/dragonfly/pull/2760)
- feat(replication): Do not auto replicate different master by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2753](https://togithub.com/dragonflydb/dragonfly/pull/2753)
- Improve Helm chart to be rendered locally and on machines where is not
the application target by [@&#8203;fafg](https://togithub.com/fafg) in
[https://github.com/dragonflydb/dragonfly/pull/2706](https://togithub.com/dragonflydb/dragonfly/pull/2706)
- chore: preparation for basic http api by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2764](https://togithub.com/dragonflydb/dragonfly/pull/2764)
- feat(server): Add metric for RDB save duration. by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2768](https://togithub.com/dragonflydb/dragonfly/pull/2768)
- chore: fix flat_dfs read tests. by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2772](https://togithub.com/dragonflydb/dragonfly/pull/2772)
- fix(ci): do not overwrite last_log_file among tests by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2759](https://togithub.com/dragonflydb/dragonfly/pull/2759)
- feat(server): support cluster replication by
[@&#8203;adiholden](https://togithub.com/adiholden) in
[https://github.com/dragonflydb/dragonfly/pull/2748](https://togithub.com/dragonflydb/dragonfly/pull/2748)
- fix: fiber preempts on read path and OnCbFinish() clears
fetched_items\_ by [@&#8203;kostasrim](https://togithub.com/kostasrim)
in
[https://github.com/dragonflydb/dragonfly/pull/2763](https://togithub.com/dragonflydb/dragonfly/pull/2763)
- chore(ci): open last_log_file in append mode by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2776](https://togithub.com/dragonflydb/dragonfly/pull/2776)
- doc(README): fix outdated expiry ranges description by
[@&#8203;enjoy-binbin](https://togithub.com/enjoy-binbin) in
[https://github.com/dragonflydb/dragonfly/pull/2779](https://togithub.com/dragonflydb/dragonfly/pull/2779)
- Benchmark runner by
[@&#8203;adiholden](https://togithub.com/adiholden) in
[https://github.com/dragonflydb/dragonfly/pull/2780](https://togithub.com/dragonflydb/dragonfly/pull/2780)
- chore(replication-tests): add cache_mode on test replication all by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2685](https://togithub.com/dragonflydb/dragonfly/pull/2685)
- feat(tiering): DiskStorage by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2770](https://togithub.com/dragonflydb/dragonfly/pull/2770)
- chore: add a boilerplate for bloom filter family by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2782](https://togithub.com/dragonflydb/dragonfly/pull/2782)
- chore: introduce conversion routines between JsonType and FlatJson by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2785](https://togithub.com/dragonflydb/dragonfly/pull/2785)
- chore: Fix memcached flags not updated by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2787](https://togithub.com/dragonflydb/dragonfly/pull/2787)
- chore: remove duplicate code from dash and simplify by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2765](https://togithub.com/dragonflydb/dragonfly/pull/2765)
- chore: disable test_cluster_slot_migration by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2788](https://togithub.com/dragonflydb/dragonfly/pull/2788)
- fix: new\[] delete\[] missmatch in disk_storage by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2792](https://togithub.com/dragonflydb/dragonfly/pull/2792)
- fix: sanitizers clang build and clean up some warnings by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2793](https://togithub.com/dragonflydb/dragonfly/pull/2793)
- chore: add bloom filter class by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2791](https://togithub.com/dragonflydb/dragonfly/pull/2791)
- chore: add SBF data structure by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2795](https://togithub.com/dragonflydb/dragonfly/pull/2795)
- chore(tiering): Disable compilation for MacOs by
[@&#8203;dranikpg](https://togithub.com/dranikpg) in
[https://github.com/dragonflydb/dragonfly/pull/2799](https://togithub.com/dragonflydb/dragonfly/pull/2799)
- chore: fix daily build by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2798](https://togithub.com/dragonflydb/dragonfly/pull/2798)
- chore: expose SBF via compact_object by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2797](https://togithub.com/dragonflydb/dragonfly/pull/2797)
- fix(ci): malloc trim on sanitizers workflow by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2794](https://togithub.com/dragonflydb/dragonfly/pull/2794)
- fix(cluster): Don't miss updates in FLUSHSLOTS by
[@&#8203;chakaz](https://togithub.com/chakaz) in
[https://github.com/dragonflydb/dragonfly/pull/2783](https://togithub.com/dragonflydb/dragonfly/pull/2783)
- feat: add bf.(m)add and bf.(m)exists commands by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2801](https://togithub.com/dragonflydb/dragonfly/pull/2801)
- fix: SBF memory leaks by
[@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2803](https://togithub.com/dragonflydb/dragonfly/pull/2803)
- chore: refactor StringFamily::Set to use CmdArgParser by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2800](https://togithub.com/dragonflydb/dragonfly/pull/2800)
- fix: propagate memcached flags to replica by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2807](https://togithub.com/dragonflydb/dragonfly/pull/2807)
- DFLYMIGRATE ACK refactoring by
[@&#8203;BorysTheDev](https://togithub.com/BorysTheDev) in
[https://github.com/dragonflydb/dragonfly/pull/2790](https://togithub.com/dragonflydb/dragonfly/pull/2790)
- feat: add master lsn and journal_executed dcheck in replica via ping
by [@&#8203;kostasrim](https://togithub.com/kostasrim) in
[https://github.com/dragonflydb/dragonfly/pull/2778](https://togithub.com/dragonflydb/dragonfly/pull/2778)
- fix: correct json response for errors by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2813](https://togithub.com/dragonflydb/dragonfly/pull/2813)
- chore: bloom test - cover corner cases by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2806](https://togithub.com/dragonflydb/dragonfly/pull/2806)
- bug(server): do not write lsn opcode to journal by
[@&#8203;adiholden](https://togithub.com/adiholden) in
[https://github.com/dragonflydb/dragonfly/pull/2814](https://togithub.com/dragonflydb/dragonfly/pull/2814)
- chore: Fix build by disabling the tests. by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2821](https://togithub.com/dragonflydb/dragonfly/pull/2821)
- fix(replication): replication with multi shard sync enabled lagging by
[@&#8203;adiholden](https://togithub.com/adiholden) in
[https://github.com/dragonflydb/dragonfly/pull/2823](https://togithub.com/dragonflydb/dragonfly/pull/2823)
- fix: io_uring/fibers bug in DnsResolve by
[@&#8203;romange](https://togithub.com/romange) in
[https://github.com/dragonflydb/dragonfly/pull/2825](https://togithub.com/dragonflydb/dragonfly/pull/2825)

##### New Contributors

- [@&#8203;manojks1999](https://togithub.com/manojks1999) made their
first contribution in
[https://github.com/dragonflydb/dragonfly/pull/2659](https://togithub.com/dragonflydb/dragonfly/pull/2659)
- [@&#8203;fafg](https://togithub.com/fafg) made their first
contribution in
[https://github.com/dragonflydb/dragonfly/pull/2706](https://togithub.com/dragonflydb/dragonfly/pull/2706)
- [@&#8203;enjoy-binbin](https://togithub.com/enjoy-binbin) made their
first contribution in
[https://github.com/dragonflydb/dragonfly/pull/2779](https://togithub.com/dragonflydb/dragonfly/pull/2779)

##### Huge thanks to all the contributors! ❤️

🇮🇱  🇺🇦

**Full Changelog**:
dragonflydb/dragonfly@v1.15.0...v1.16.0

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNzkuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI3OS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL21pbm9yIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dranikpg dranikpg dranikpg approved these changes

@romange romange Awaiting requested review from romange

Assignees

@kostasrim kostasrim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostasrim @dranikpg @romange