Skip to content

Namespace support in prometheus rule #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Namespace support in prometheus rule #2796

wants to merge 0 commits into from

Conversation

yjagdale
Copy link
Contributor

@yjagdale yjagdale commented Mar 29, 2024 •
edited
Loading

Added support for namespace in the Prometheus rules. The original PR was #2694

@yjagdale
Copy link
Contributor Author

yjagdale commented Mar 29, 2024 •
edited
Loading

Hey @Pothulapati, @romange - Please have a look at this one. Sorry for the late response to review comments.

--Yash

@yjagdale yjagdale changed the title helm templating and test cases for namespace support in prometheus ru… helm templating and test cases for namespace support in prometheus rule Mar 29, 2024
@yjagdale yjagdale changed the title helm templating and test cases for namespace support in prometheus rule Namespace support in prometheus rule Mar 29, 2024
@yjagdale
Copy link
Contributor Author

Fixed linting issues for both files.

@romange
Copy link
Collaborator

romange commented Apr 10, 2024

@Pothulapati PTAL

@romange romange requested a review from Pothulapati April 10, 2024 11:47
Pothulapati
Pothulapati reviewed Apr 10, 2024
View reviewed changes
contrib/charts/dragonfly/ci/prometheusrules-values.yaml Outdated
serviceMonitor:
enabled: true
prometheusRule:
enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the namespace to verify the same? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks! (It still doesn't update the golden file as the main constraint ( .Capabilities.APIVersions.Has "monitoring.coreos.com/v1" ) doesn't return true on my local)

@romange
Copy link
Collaborator

romange commented Apr 17, 2024

@Pothulapati can I merge it?

@Pothulapati
Copy link
Contributor

Okay! Not sure why this got closed, I just tried pushing a commit. Will raise a new PR

@yjagdale
Copy link
Contributor Author

Can I raise new PR from yjagdale:main to main.

@Pothulapati Pothulapati mentioned this pull request Apr 19, 2024
Merged
@Pothulapati
Copy link
Contributor

@yjagdale Didn't want to waste more of your time. Raised it, and got it merged! sorry for the late review, and laso the PR getting closed! :/ Thanks for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Pothulapati Pothulapati Pothulapati approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yjagdale @romange @Pothulapati