Skip to content

fix: crash during migration when connection is closing #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2024
Merged

fix: crash during migration when connection is closing #2973

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b233246
fix: crash during migration when connection is closing
kostasrim Apr 29, 2024
2814995
address gh comments
kostasrim Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/facade/dragonfly_connection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1452,7 +1452,7 @@ bool Connection::Migrate(util::fb2::ProactorBase* dest) {
CHECK(!cc_->async_dispatch);
CHECK_EQ(cc_->subscriptions, 0); // are bound to thread local caches
CHECK_EQ(self_.use_count(), 1u); // references cache our thread and backpressure
if (dispatch_fb_.IsJoinable()) { // can't move once it started
if (dispatch_fb_.IsJoinable() || cc_->conn_closing) { // can't move once it started
return false;
}

Expand Down