Skip to content

Conversation

KIMDONGYEON00
Copy link
Contributor

@KIMDONGYEON00 KIMDONGYEON00 commented Mar 30, 2025

~/Desktop/dragonfly/build$ ./interpreter_test 
[==========] Running 16 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 16 tests from InterpreterTest
[ RUN      ] InterpreterTest.Basic
[       OK ] InterpreterTest.Basic (0 ms)
[ RUN      ] InterpreterTest.UnknownFunc
[       OK ] InterpreterTest.UnknownFunc (0 ms)
[ RUN      ] InterpreterTest.Stack
[       OK ] InterpreterTest.Stack (0 ms)
[ RUN      ] InterpreterTest.Add
[       OK ] InterpreterTest.Add (0 ms)
[ RUN      ] InterpreterTest.Execute
[       OK ] InterpreterTest.Execute (0 ms)
[ RUN      ] InterpreterTest.Call
[       OK ] InterpreterTest.Call (0 ms)
[ RUN      ] InterpreterTest.CallArray
[       OK ] InterpreterTest.CallArray (0 ms)
[ RUN      ] InterpreterTest.ArgKeys
[       OK ] InterpreterTest.ArgKeys (0 ms)
[ RUN      ] InterpreterTest.Modules
[       OK ] InterpreterTest.Modules (0 ms)
[ RUN      ] InterpreterTest.Compatibility
[       OK ] InterpreterTest.Compatibility (0 ms)
[ RUN      ] InterpreterTest.AsyncReplacement
[       OK ] InterpreterTest.AsyncReplacement (0 ms)
[ RUN      ] InterpreterTest.ReplicateCommands
[       OK ] InterpreterTest.ReplicateCommands (0 ms)
[ RUN      ] InterpreterTest.Log
[       OK ] InterpreterTest.Log (0 ms)
[ RUN      ] InterpreterTest.Robust
[       OK ] InterpreterTest.Robust (0 ms)
[ RUN      ] InterpreterTest.Unpack
[       OK ] InterpreterTest.Unpack (1 ms)
[ RUN      ] InterpreterTest.AvoidIntOverflow
[       OK ] InterpreterTest.AvoidIntOverflow (0 ms)
[----------] 16 tests from InterpreterTest (4 ms total)

[----------] Global test environment tear-down
[==========] 16 tests from 1 test suite ran. (4 ms total)
[  PASSED  ] 16 tests.

@romange
Copy link
Collaborator

romange commented Mar 30, 2025

Thanks for submitting the fix. Can you pls add the test to interpreter_test

@KIMDONGYEON00
Copy link
Contributor Author

Thanks for submitting the fix. Can you pls add the test to interpreter_test

I edited the text and passed all the test cases.

@romange
Copy link
Collaborator

romange commented Mar 30, 2025

@KIMDONGYEON00 thanks but I meant adding a new test there running EVAL "return bit.tohex(65535, -2147483648)" 0

@KIMDONGYEON00
Copy link
Contributor Author

KIMDONGYEON00 commented Mar 30, 2025

@KIMDONGYEON00 thanks but I meant adding a new test there running EVAL "return bit.tohex(65535, -2147483648)" 0

Sorry, I've fixed it and amended the commit.

romange
romange previously approved these changes Mar 30, 2025
@romange
Copy link
Collaborator

romange commented Mar 30, 2025

@KIMDONGYEON00
Copy link
Contributor Author

@romange romange enabled auto-merge (squash) March 30, 2025 15:04
@romange romange merged commit 4612aec into dragonflydb:main Mar 30, 2025
10 checks passed
@romange
Copy link
Collaborator

romange commented Mar 30, 2025

Thank you @KIMDONGYEON00 for your contribution!

@KIMDONGYEON00 KIMDONGYEON00 deleted the fix-lua-stack-overflow branch July 5, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lua library stack overflow can cause the Dragonfly crash. (CVE-2024-31449)
2 participants