fix: test_replica_snapshot_with_big_values_while_seeding #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
|
https://github.com/dragonflydb/dragonfly/actions/runs/14333160078/job/40173660335 took I increased to 60 |
adiholden
reviewed
Apr 9, 2025
| @@ -2999,7 +2998,7 @@ async def test_replica_snapshot_with_big_values_while_seeding(df_factory: DflyIn | |||
| c_replica = replica.client() | |||
|
|
|||
| # 50% big values | |||
| seeder_config = dict(key_target=20_000, huge_value_target=10000) | |||
| seeder_config = dict(key_target=8_000, huge_value_target=4_000) | |||
There was a problem hiding this comment.
Ok for this change, though I suspect it will not be stable for long because you check the side_saved. I suggest to follow up with a PR that will add a flag to yield on x buckets granularity in snapshot as we have in migration
adiholden
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally, the test consumes roughly 8gb of memory. Our gh runner has 7.5GB.
Solution: lower number of seeded keys
Also increase timeout for reg tests. It seems that we timeout now :)
Resolves #4899