fix(set_family): Transfer TTL flag from DenseLink object in delete #4947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorysTheDev
previously approved these changes
Apr 16, 2025
kostasrim
reviewed
Apr 16, 2025
romange
reviewed
Apr 16, 2025
| @@ -412,4 +412,17 @@ TEST_F(SetFamilyTest, SAddEx) { | |||
| EXPECT_THAT(Run({"saddex", "key", "KEEPTTL", "2"}), ErrArg("wrong number of arguments")); | |||
| } | |||
|
|
|||
| TEST_F(SetFamilyTest, CheckSetLinkExpiryTransfer) { | |||
There was a problem hiding this comment.
can you please add an equivalent test in src/core/string_set_test.cc, @mkaruza ?
When extracting DensePtr from LinkObject we need to transfer TTL flag before this DensePtr is assigned. Fixes #3915 Signed-off-by: mkaruza <[email protected]>
mkaruza
force-pushed
the
mkaruza/github#3915
branch
from
1b6c204 to
32f15b4
Compare
romange
approved these changes
Apr 17, 2025
romange
pushed a commit
that referenced
this pull request
Apr 17, 2025
…4947) fix(set_family): Transfer TTL flag from link to object in delete When extracting DensePtr from LinkObject we need to transfer TTL flag before this DensePtr is assigned. Fixes #3915 Signed-off-by: mkaruza <[email protected]>
romange
pushed a commit
that referenced
this pull request
Apr 17, 2025
…4947) fix(set_family): Transfer TTL flag from link to object in delete When extracting DensePtr from LinkObject we need to transfer TTL flag before this DensePtr is assigned. Fixes #3915 Signed-off-by: mkaruza <[email protected]>
kostasrim
pushed a commit
that referenced
this pull request
Apr 22, 2025
…4947) fix(set_family): Transfer TTL flag from link to object in delete When extracting DensePtr from LinkObject we need to transfer TTL flag before this DensePtr is assigned. Fixes #3915 Signed-off-by: mkaruza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting DensePtr from LinkObject we need to transfer TTL flag before this DensePtr is assigned.
Fixes #3915