Skip to content

Conversation

mkaruza
Copy link
Contributor

@mkaruza mkaruza commented Sep 8, 2025

Fixes #5777

@mkaruza mkaruza requested review from romange and kostasrim September 8, 2025 11:07
@Niennienzz
Copy link
Contributor

Thanks for the fix! @mkaruza

Without understanding the code, I would like to double-check and make sure that this behavior of scanning is preserved.

Basically, during a full iteration:

The scan commands are also allowed to return zero elements, and the client should not consider the iteration complete as long as the returned cursor is not zero.

^ In that case, the client should continue scanning.

Unlike the non-existing key case described in the issue, where the client should stop as it gets cursor 0.

@mkaruza
Copy link
Contributor Author

mkaruza commented Sep 9, 2025

@Niennienzz can you let me know after you double check if this is correct

@romange romange added this to the v1.34 milestone Sep 9, 2025
@romange romange merged commit f76f9a7 into main Sep 11, 2025
10 checks passed
@romange romange deleted the mkaruza/github#5777 branch September 11, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HSCAN/SSCAN/ZSCAN on non-existing keys should return zero cursor
3 participants