Skip to content

Fixes transfer() issues #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fixes transfer() issues #579

merged 2 commits into from
Dec 4, 2023

Conversation

luizluca
Copy link
Contributor

  • use subshell to avoid leaking vars to current shell
  • use POSIX 'test -t' instead of tty
  • have a single place to call curl
  • echo the output url to add the carrier return when needed.
  • use printf to process \n
  • silence curl instead of teeing /dev/null

@luizluca
Fixes transfer() issues
36c7225 
- use subshell to avoid leaking vars to current shell
- use POSIX 'test -t' instead of tty
- have a single place to call curl
- echo the output url to add the carrier return when needed.
- use printf to process \n
- silence curl instead of teeing /dev/null
@aspacca aspacca merged commit a6f197a into dutchcoders:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspacca aspacca aspacca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizluca @aspacca