Fix drop on mounted after start #2526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libcore/FileUtils.vala
jeremypw
added
the
Good First Issue
danirabbit
reviewed
Mar 11, 2025
There was a problem hiding this comment.
I guess this technically fixes the issue but I don't think this is the expected behavior. It seems like the expectation is that the drive would be mounted so that the drop operation succeeds.
If that's significantly more difficult, I can see this as like a hotfix, but I don't think it really solves the problem as far as giving the intended result
|
@danirabbit Fair enough - I'll work on automounting. I note that there is one issue that this does completely fix? Are you willing to merge on that basis and I'll submit a further PR in due course? |
jeremypw
removed
the
Good First Issue
danirabbit
approved these changes
Mar 12, 2025
jeremypw
changed the title
jeremypw
changed the title
|
I've left a comment on #2390 making it clear that the mount should be automounted so I do not think another report is required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2465
Sets target file to null when bookmark not mounted and not accepts drop of target_file if null.
NOTE: Ignore first commit - this solution is not reliable as the File property
is_mountedreturns false for local files at the moment. Better to rely on presence of mount object in bookmark.