stm32/adc/v3: Add method to sample ADC without reconfiguring every time #4450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, I didn't touch it because I was unsure if there was a good reason, but why is continuous conversion mode used if we stop the ADC after receiving the first conversion? Wouldn't it be simpler to just use single conversion mode? |
Jacke-debug
reviewed
Sep 18, 2025
| } | ||
|
|
||
| /// Configure the ADC peripheral with the given channels for reading with DMA | ||
| pub async fn prepare_read(&mut self, sequence: impl ExactSizeIterator<Item = (&mut AnyAdcChannel<T>, SampleTime)>) { |
There was a problem hiding this comment.
I suggest to rename this method to configure_regular_sequence to make the distinction between regular and injected more clear.
Jacke-debug
reviewed
Sep 18, 2025
| /// defmt::info!("measurements: {}", measurements); | ||
| /// } | ||
| /// ``` | ||
| pub async fn read_without_preparing(&mut self, rx_dma: Peri<'_, impl RxDma<T>>, readings: &mut [u16]) { |
There was a problem hiding this comment.
I suggest to rename this to something like "trigger_regular_conversion_and_await_result" (maybe a bit long but I think you get the point).
We may also want to think about how we can add support for non-software triggered ADC measurements in the future by setting the EXTEN bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the ADC and channel configuration code to a new public function
prepare_read, then adds aread_without_preparingfunction which just starts a DMA transfer and starts conversion. This reduces wasted time reconfiguring the same channels repeatedly.Tested on my STM32WB55RG