Skip to content

Conversation

naftaly
Copy link
Collaborator

@naftaly naftaly commented Jun 30, 2025

View and Modifier to tell the system what view's in SwiftUI should be treated as a Surface.

Copy link

github-actions bot commented Jun 30, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link

github-actions bot commented Jun 30, 2025

Warnings
⚠️ No CHANGELOG entry added.
⚠️ No tests added / modified.

Generated by 🚫 Danger Swift against e2e5234

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

❌ Patch coverage is 0.39683% with 251 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.36%. Comparing base (9f19752) to head (4736605).

Files with missing lines Patch % Lines
...eCore/SwiftUI/Internal/EmbraceSurfaceTracker.swift 0.00% 104 Missing ⚠️
...Core/SwiftUI/Internal/EmbraceSurfaceInternal.swift 0.00% 70 Missing ⚠️
.../EmbraceCore/SwiftUI/EmbraceTraceSurfaceView.swift 0.00% 47 Missing ⚠️
...Core/SwiftUI/Internal/EmbraceTraceViewLogger.swift 4.54% 21 Missing ⚠️
...es/EmbraceCore/SwiftUI/EmbraceTraceModifiers.swift 0.00% 5 Missing ⚠️
...e/SwiftUI/Internal/EmbraceSurfaceEnvironment.swift 0.00% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.39%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #291      +/-   ##
==========================================
+ Coverage   83.51%   89.36%   +5.85%     
==========================================
  Files         440      479      +39     
  Lines       27121    30597    +3476     
==========================================
+ Hits        22650    27344    +4694     
+ Misses       4471     3253    -1218     
Files with missing lines Coverage Δ
...e/SwiftUI/Internal/EmbraceSurfaceEnvironment.swift 0.00% <0.00%> (ø)
...es/EmbraceCore/SwiftUI/EmbraceTraceModifiers.swift 0.00% <0.00%> (ø)
...Core/SwiftUI/Internal/EmbraceTraceViewLogger.swift 67.90% <4.54%> (+67.90%) ⬆️
.../EmbraceCore/SwiftUI/EmbraceTraceSurfaceView.swift 0.00% <0.00%> (ø)
...Core/SwiftUI/Internal/EmbraceSurfaceInternal.swift 0.00% <0.00%> (ø)
...eCore/SwiftUI/Internal/EmbraceSurfaceTracker.swift 0.00% <0.00%> (ø)

... and 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@naftaly naftaly force-pushed the acohen/trace-surface branch 2 times, most recently from cf05c96 to ecb4a2d Compare July 15, 2025 20:36
@naftaly naftaly force-pushed the acohen/trace-surface branch 2 times, most recently from d063922 to 779ca8b Compare July 23, 2025 19:46
@naftaly naftaly force-pushed the acohen/trace-surface branch 3 times, most recently from c9d9882 to de5b371 Compare July 31, 2025 14:14
@naftaly naftaly force-pushed the acohen/trace-surface branch 4 times, most recently from 57de9b3 to 76772d1 Compare August 11, 2025 15:25
@naftaly naftaly force-pushed the acohen/trace-surface branch from 76772d1 to c8021b4 Compare August 18, 2025 21:06
@naftaly naftaly force-pushed the acohen/trace-surface branch 3 times, most recently from 4b3c6aa to dc91f24 Compare September 2, 2025 14:18
@naftaly naftaly force-pushed the acohen/trace-surface branch from dc91f24 to cd563d6 Compare September 5, 2025 02:09
Copy link

github-actions bot commented Sep 5, 2025

🚀 Perf Comparison (PR vs Main)

Threshold: 5.0%, α = 0.05

Test PR Avg (s) Main Avg (s) Δ vs Main p Status
test_embraceStartBasic() 0.025 0.027 -8.12% 0.667 🟢 ok
test_embraceStartSimple() 0.013 0.016 -20.64% 0.858 🟢 ok
test_noopMainActorIsolated() 0.001 0.001 +20.53% 0.25 🟢 ok
test_noopNotIsolated() 0.003 0.006 -48.40% 0.691 🟢 ok
BenchmarksUITests/testLaunchPerformance() 8.499 3.816 +122.70% 0.161 🟢 ok
BenchmarksUITests/testLaunchPerformanceNoop() 9.655 7.173 +34.60% 0.356 🟢 ok

@naftaly naftaly force-pushed the acohen/trace-surface branch from cd563d6 to 1d4d681 Compare September 10, 2025 15:04
@naftaly naftaly force-pushed the acohen/trace-surface branch from 44a8879 to 4736605 Compare September 23, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant