redis_proxy: Add support for per-upstream auth credentials #41212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to use upstream redis clusters which each have different usernames and/or passwords. The credentials are keyed with an `address`, which must be a socket address and matches against the upstream based on the port along with the hostname or IP address. Tested: Unit and integration tests, as well as manual testing and using in production at my company for a couple months Fixes: envoyproxy#23962 Signed-off-by: Ben Breslauer <[email protected]>
|
Hi @bb8gh, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: redis_proxy: Add support for per-upstream auth credentials
Additional Description: This adds the ability to use upstream redis clusters which each have different usernames and/or passwords. The credentials are keyed with an
address, which must be a socket address and matches against the upstream based on the port along with the hostname or IP address.Risk Level: Low
Testing: Unit and integration tests, as well as manual testing and using in production at my company for a couple months
Docs Changes: Yes, docs/root and api proto comments
Release Notes: Yes
Platform Specific Features: None
Fixes: #23962