Skip to content

Conversation

missBerg
Copy link
Contributor

What type of PR is this?
Following up on PR #6399 to add a link to the Benchmark Report Explorer Tool.
I created a Tools page where we can have links to more tools as well in the future.

What this PR does / why we need it:
Make it easy to find tools.

Screenshot:
localhost_1313_tools_

Which issue(s) this PR fixes:
N/A

Release Notes: No

Signed-off-by: Erica Hughberg <[email protected]>
@missBerg missBerg requested a review from a team as a code owner June 25, 2025 21:40
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.79%. Comparing base (b88a7a5) to head (81777ba).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6407      +/-   ##
==========================================
- Coverage   70.80%   70.79%   -0.02%     
==========================================
  Files         220      220              
  Lines       37132    37132              
==========================================
- Hits        26291    26286       -5     
- Misses       9300     9304       +4     
- Partials     1541     1542       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -1,6 +1,6 @@
---
title: "Performance Benchmark Report Explorer"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt the title too wordy ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's descriptive :) think we don't need to overthink it

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

there's a lot of room from improvement here. especially on the generation side, thanks for surfacing these

@arkodg arkodg requested review from a team June 25, 2025 22:05
@zhaohuabing
Copy link
Member

/retest

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks @missBerg !

@Xunzhuo Xunzhuo merged commit 7bb4535 into envoyproxy:main Jun 26, 2025
47 of 50 checks passed
crhuber pushed a commit to crhuber/gateway that referenced this pull request Jun 26, 2025
add tools page

Signed-off-by: Erica Hughberg <[email protected]>
Signed-off-by: crhuber <[email protected]>
davem-git pushed a commit to davem-git/gateway that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants