Default to 1 for MaxAcceptPerSocketEvent #6447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jukie <[email protected]>
jukie
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6447 +/- ##
==========================================
- Coverage 70.92% 70.87% -0.06%
==========================================
Files 220 220
Lines 37260 37263 +3
==========================================
- Hits 26426 26409 -17
- Misses 9289 9305 +16
- Partials 1545 1549 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: jukie <[email protected]>
rudrakhp
reviewed
Jul 2, 2025
internal/xds/translator/testdata/out/xds-ir/max-conn-per-socket-event.listeners.yaml
Show resolved
Hide resolved
rudrakhp
reviewed
Jul 2, 2025
Signed-off-by: jukie <[email protected]>
rudrakhp
reviewed
Jul 2, 2025
Co-authored-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: Isaac <[email protected]>
Signed-off-by: jukie <[email protected]>
|
/retest |
rudrakhp
approved these changes
Jul 2, 2025
|
/retest |
davem-git
pushed a commit
to davem-git/gateway
that referenced
this pull request
Jul 8, 2025
* Add default=1 for MaxAcceptPerSocketEvent Signed-off-by: jukie <[email protected]> * testdata Signed-off-by: jukie <[email protected]> * Fix default Signed-off-by: jukie <[email protected]> * Update internal/xds/translator/listener.go Co-authored-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: Isaac <[email protected]> * update const name Signed-off-by: jukie <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: Isaac <[email protected]> Co-authored-by: Rudrakh Panigrahi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: default to 1 for MaxAcceptPerSocketEvent
What this PR does / why we need it:
It's recommended to set a value for MaxAcceptPerSocketEvent and 1 is a safe value with either negligible or zero performance impact which other Gateway Controllers use as well.
Which issue(s) this PR fixes:
Fixes #6439
Release Notes: No