fix: allow imageRepository contains port #6658

woodgear · 2025-07-31T09:41:18Z

What type of PR is this?

"fix: fix allow imageRepository contains port"

Which issue(s) this PR fixes:
#6657

woodgear · 2025-07-31T09:42:05Z

@sudiptob2 @shawnh2
i thought this pr should be cherry-pick to master either.

woodgear · 2025-07-31T09:54:18Z

https://regex101.com/r/TcLWMA/1

rudrakhp · 2025-07-31T09:59:59Z

@woodgear please make sure to run make -k gen-check and update CEL validation tests since error message has changed. Also you will need to add the new usecase as a test in the CEL tests and not unit tests since this is a CEL validation.
PS: Also fix the DCO (see View Details on the failed workflow on how to fix it)

woodgear · 2025-07-31T10:00:32Z

ok

codecov · 2025-07-31T11:25:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.11%. Comparing base (dedc40d) to head (7376d69).
⚠️ Report is 1 commits behind head on release/v1.5.

Additional details and impacted files

@@               Coverage Diff                @@
##           release/v1.5    #6658      +/-   ##
================================================
+ Coverage         71.06%   71.11%   +0.04%     
================================================
  Files               225      225              
  Lines             39488    39488              
================================================
+ Hits              28063    28082      +19     
+ Misses             9804     9789      -15     
+ Partials           1621     1617       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: cong <[email protected]>

arkodg · 2025-07-31T16:57:03Z

I missed the branch this was being merged in, it should have ideally gone into main first and then cherry picked into v1.5 (the release manager usually cherry picks in bulk)

(cherry picked from commit c988ec5)

(cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]>

zirain · 2025-08-01T01:24:48Z

I missed the branch this was being merged in, it should have ideally gone into main first and then cherry picked into v1.5 (the release manager usually cherry picks in bulk)

let's revert first?

(cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]>

…y#6660) (cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]>

…y#6660) (cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Signed-off-by: zirain <[email protected]>

* chore: cleanups from #6597 (#6647) Cleanup Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * fix: set order for grpc_web and grpc_stats filters (#6626) * set order for grpc_web and grpc_stats filters Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: nil pointer when InsecureSkipVerify is true (#6652) * fix nil pointer when InsecureSkipVerify is true Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * delete cacert for the xds translator test Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: allow imageRepository contains port (#6658) (#6660) (cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Signed-off-by: zirain <[email protected]> * docs: improve policy concepts section (#6663) better explain * targets * precedence * merge types Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: observability pre req not required in admin console page (#6662) Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: xds name scheme v2 (#6656) * name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: highlight wait step (#6665) * docs: highlight wait step Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: populate status for custom backendRef not found (#6670) Signed-off-by: bitliu <[email protected]> Signed-off-by: zirain <[email protected]> * fix: xds name schema v2 (#6638) * rename route config Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename HCM statPrefix Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename virtual host Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * minor change Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: expand Gateway Namespace Mode doc on client/server auth (#6616) * Expand Gateway Namespace Mode doc on client/server auth Signed-off-by: Karol Szwaj <[email protected]> * Add additional explanation to the overview Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: zirain <[email protected]> * increase earlyRequestHeaders from 16 to 64 (#6673) * created a new definition of HTTPFilterHeader that supports 64 items for `set`, `add`, and `remove` * sanitizing request headers from untrusted downstream traffic is a common use case and 16 items may not be adequate enough at times. This action needs to be performed route processing for cases and the HTTPRoute filters cannot be used Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: skipping TLS verification (#6653) * docs for skipping TLS verification Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove btlsp for skiptlsverify Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove public Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * feat: add listener metadata (#6639) * add listener metadata Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove sort Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: Fix BTP ZoneAware translation (#6668) * Fix BTP ZoneAware translation Signed-off-by: jukie <[email protected]> * Add e2e Signed-off-by: jukie <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * docs: unhide zoneaware api for docs (#6683) unhide api docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * watchable: use Store directly instead of HandleStore wrapper (#6680) * watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to #6406 Signed-off-by: Arko Dasgupta <[email protected]> * fix test Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: Update Zone Aware Routing for BackendTrafficPolicy configuration example (#6667) Update zone aware routing docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * combine the xds-translator and xds-server runner into one (#6586) * combine the xds-translator and xds-server into one xds runner * primarily to reduce memory and convergence time Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * build(deps): bump the gomod group across 1 directory with 6 updates (#6691) * build(deps): bump the gomod group across 1 directory with 6 updates Bumps the gomod group with 4 updates in the / directory: [github.com/miekg/dns](https://github.com/miekg/dns), [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang), [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) and [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go). Updates `github.com/miekg/dns` from 1.1.67 to 1.1.68 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.67...v1.1.68) Updates `github.com/prometheus/client_golang` from 1.22.0 to 1.23.0 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.22.0...v1.23.0) Updates `github.com/quic-go/quic-go` from 0.52.0 to 0.54.0 - [Release notes](https://github.com/quic-go/quic-go/releases) - [Commits](quic-go/quic-go@v0.52.0...v0.54.0) Updates `go.opentelemetry.io/proto/otlp` from 1.7.0 to 1.7.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v1.7.0...v1.7.1) Updates `google.golang.org/genproto/googleapis/api` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) --- updated-dependencies: - dependency-name: github.com/miekg/dns dependency-version: 1.1.68 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/prometheus/client_golang dependency-version: 1.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: github.com/quic-go/quic-go dependency-version: 0.54.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: go.opentelemetry.io/proto/otlp dependency-version: 1.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/api dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/rpc dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: indirect update-type: version-update:semver-patch dependency-group: gomod ... Signed-off-by: dependabot[bot] <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <[email protected]> Signed-off-by: zirain <[email protected]> * fix: controller panic when reloading config (#6688) * fix controller panic when reloading config Signed-off-by: zirain <[email protected]> * use gwapiv1.Duration instead of metav1.Duration (#6664) * use gwapiv1.Duration instead of metav1.Duration fixes: #4746 Signed-off-by: Arko Dasgupta <[email protected]> * add charts Signed-off-by: Arko Dasgupta <[email protected]> * go back to metav1 in IR to make YAML tests happy Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * fix: don't block deployment creating when missing secret in EnvoyProxy (#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <[email protected]> * [release/v1.5] release notes for rc.2 (#6697) * [release/v1.5] release notes for rc.2 Signed-off-by: zirain <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: bitliu <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Isaac <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: zirain <[email protected]>

* chore: cleanups from envoyproxy#6597 (envoyproxy#6647) Cleanup Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * fix: set order for grpc_web and grpc_stats filters (envoyproxy#6626) * set order for grpc_web and grpc_stats filters Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: nil pointer when InsecureSkipVerify is true (envoyproxy#6652) * fix nil pointer when InsecureSkipVerify is true Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * delete cacert for the xds translator test Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: allow imageRepository contains port (envoyproxy#6658) (envoyproxy#6660) (cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Signed-off-by: zirain <[email protected]> * docs: improve policy concepts section (envoyproxy#6663) better explain * targets * precedence * merge types Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: observability pre req not required in admin console page (envoyproxy#6662) Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: xds name scheme v2 (envoyproxy#6656) * name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: highlight wait step (envoyproxy#6665) * docs: highlight wait step Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: populate status for custom backendRef not found (envoyproxy#6670) Signed-off-by: bitliu <[email protected]> Signed-off-by: zirain <[email protected]> * fix: xds name schema v2 (envoyproxy#6638) * rename route config Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename HCM statPrefix Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename virtual host Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * minor change Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: expand Gateway Namespace Mode doc on client/server auth (envoyproxy#6616) * Expand Gateway Namespace Mode doc on client/server auth Signed-off-by: Karol Szwaj <[email protected]> * Add additional explanation to the overview Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: zirain <[email protected]> * increase earlyRequestHeaders from 16 to 64 (envoyproxy#6673) * created a new definition of HTTPFilterHeader that supports 64 items for `set`, `add`, and `remove` * sanitizing request headers from untrusted downstream traffic is a common use case and 16 items may not be adequate enough at times. This action needs to be performed route processing for cases and the HTTPRoute filters cannot be used Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: skipping TLS verification (envoyproxy#6653) * docs for skipping TLS verification Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove btlsp for skiptlsverify Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove public Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * feat: add listener metadata (envoyproxy#6639) * add listener metadata Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove sort Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: Fix BTP ZoneAware translation (envoyproxy#6668) * Fix BTP ZoneAware translation Signed-off-by: jukie <[email protected]> * Add e2e Signed-off-by: jukie <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * docs: unhide zoneaware api for docs (envoyproxy#6683) unhide api docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * watchable: use Store directly instead of HandleStore wrapper (envoyproxy#6680) * watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to envoyproxy#6406 Signed-off-by: Arko Dasgupta <[email protected]> * fix test Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: Update Zone Aware Routing for BackendTrafficPolicy configuration example (envoyproxy#6667) Update zone aware routing docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * combine the xds-translator and xds-server runner into one (envoyproxy#6586) * combine the xds-translator and xds-server into one xds runner * primarily to reduce memory and convergence time Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * build(deps): bump the gomod group across 1 directory with 6 updates (envoyproxy#6691) * build(deps): bump the gomod group across 1 directory with 6 updates Bumps the gomod group with 4 updates in the / directory: [github.com/miekg/dns](https://github.com/miekg/dns), [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang), [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) and [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go). Updates `github.com/miekg/dns` from 1.1.67 to 1.1.68 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.67...v1.1.68) Updates `github.com/prometheus/client_golang` from 1.22.0 to 1.23.0 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.22.0...v1.23.0) Updates `github.com/quic-go/quic-go` from 0.52.0 to 0.54.0 - [Release notes](https://github.com/quic-go/quic-go/releases) - [Commits](quic-go/quic-go@v0.52.0...v0.54.0) Updates `go.opentelemetry.io/proto/otlp` from 1.7.0 to 1.7.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v1.7.0...v1.7.1) Updates `google.golang.org/genproto/googleapis/api` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) --- updated-dependencies: - dependency-name: github.com/miekg/dns dependency-version: 1.1.68 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/prometheus/client_golang dependency-version: 1.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: github.com/quic-go/quic-go dependency-version: 0.54.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: go.opentelemetry.io/proto/otlp dependency-version: 1.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/api dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/rpc dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: indirect update-type: version-update:semver-patch dependency-group: gomod ... Signed-off-by: dependabot[bot] <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <[email protected]> Signed-off-by: zirain <[email protected]> * fix: controller panic when reloading config (envoyproxy#6688) * fix controller panic when reloading config Signed-off-by: zirain <[email protected]> * use gwapiv1.Duration instead of metav1.Duration (envoyproxy#6664) * use gwapiv1.Duration instead of metav1.Duration fixes: envoyproxy#4746 Signed-off-by: Arko Dasgupta <[email protected]> * add charts Signed-off-by: Arko Dasgupta <[email protected]> * go back to metav1 in IR to make YAML tests happy Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * fix: don't block deployment creating when missing secret in EnvoyProxy (envoyproxy#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <[email protected]> * [release/v1.5] release notes for rc.2 (envoyproxy#6697) * [release/v1.5] release notes for rc.2 Signed-off-by: zirain <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: bitliu <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Isaac <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: zirain <[email protected]>

woodgear requested a review from a team as a code owner July 31, 2025 09:41

woodgear changed the title ~~allow imageRepository contains port~~ feat: allow imageRepository contains port Jul 31, 2025

woodgear force-pushed the fix/support-imageregistry-with-port branch 2 times, most recently from d5bce9c to 597fdfc Compare July 31, 2025 09:53

woodgear changed the title ~~feat: allow imageRepository contains port~~ fix: allow imageRepository contains port Jul 31, 2025

woodgear force-pushed the fix/support-imageregistry-with-port branch from 597fdfc to f866de9 Compare July 31, 2025 11:11

allow imageRepository contains port

7376d69

Signed-off-by: cong <[email protected]>

woodgear force-pushed the fix/support-imageregistry-with-port branch from f866de9 to 7376d69 Compare July 31, 2025 12:18

arkodg added this to the v1.5.0 Release milestone Jul 31, 2025

arkodg approved these changes Jul 31, 2025

View reviewed changes

arkodg requested review from a team July 31, 2025 14:36

jukie approved these changes Jul 31, 2025

View reviewed changes

rudrakhp approved these changes Jul 31, 2025

View reviewed changes

rudrakhp merged commit c988ec5 into envoyproxy:release/v1.5 Jul 31, 2025
24 checks passed

arkodg pushed a commit to arkodg/gateway that referenced this pull request Jul 31, 2025

fix: allow imageRepository contains port (envoyproxy#6658)

e189d43

(cherry picked from commit c988ec5)

arkodg pushed a commit to arkodg/gateway that referenced this pull request Jul 31, 2025

fix: allow imageRepository contains port (envoyproxy#6658)

e4d0b26

(cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]>

zirain pushed a commit that referenced this pull request Aug 1, 2025

fix: allow imageRepository contains port (#6658) (#6660)

03912b6

(cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]>

woodgear deleted the fix/support-imageregistry-with-port branch August 1, 2025 02:16

zirain pushed a commit to zirain/gateway that referenced this pull request Sep 16, 2025

fix: allow imageRepository contains port (envoyproxy#6658)

2f3cebd

Signed-off-by: zirain <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: allow imageRepository contains port #6658

fix: allow imageRepository contains port #6658

Uh oh!

woodgear commented Jul 31, 2025 •

edited

Loading

Uh oh!

woodgear commented Jul 31, 2025 •

edited

Loading

Uh oh!

woodgear commented Jul 31, 2025

Uh oh!

rudrakhp commented Jul 31, 2025 •

edited

Loading

Uh oh!

woodgear commented Jul 31, 2025

Uh oh!

codecov bot commented Jul 31, 2025 •

edited

Loading

Uh oh!

Uh oh!

arkodg commented Jul 31, 2025

Uh oh!

zirain commented Aug 1, 2025

Uh oh!

Uh oh!

fix: allow imageRepository contains port #6658

fix: allow imageRepository contains port #6658

Uh oh!

Conversation

woodgear commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

woodgear commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

woodgear commented Jul 31, 2025

Uh oh!

rudrakhp commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

woodgear commented Jul 31, 2025

Uh oh!

codecov bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

arkodg commented Jul 31, 2025

Uh oh!

zirain commented Aug 1, 2025

Uh oh!

Uh oh!

woodgear commented Jul 31, 2025 •

edited

Loading

woodgear commented Jul 31, 2025 •

edited

Loading

rudrakhp commented Jul 31, 2025 •

edited

Loading

codecov bot commented Jul 31, 2025 •

edited

Loading