Bump sigs.k8s.io/controller-tools from 0.18.0 to 0.19.0 in /tools/mod #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dependabot
bot
force-pushed
the
dependabot/go_modules/tools/mod/sigs.k8s.io/controller-tools-0.19.0
branch
from
23048a2 to
3130b49
Compare
|
/ok-to-test |
|
/rebase |
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/go_modules/tools/mod/sigs.k8s.io/controller-tools-0.19.0
branch
from
3130b49 to
09bd2c8
Compare
|
@dependabot rebase |
Bumps [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) from 0.18.0 to 0.19.0. - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/main/envtest-releases.yaml) - [Commits](kubernetes-sigs/controller-tools@v0.18.0...v0.19.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-tools dependency-version: 0.19.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/tools/mod/sigs.k8s.io/controller-tools-0.19.0
branch
from
09bd2c8 to
485a7bc
Compare
ahrtr
approved these changes
Sep 8, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, dependabot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dependabot
bot
deleted the
dependabot/go_modules/tools/mod/sigs.k8s.io/controller-tools-0.19.0
branch
|
Noting that this pull request broke |
Merged
|
thx, that's why we need a workflow to verify it. Let's stop bumping any deps before the workflow is ready. |
|
The problem is that there's no current solution for this. If we want the check from #212 to be green, we need to revert this pull request (and possibly update it in the next controller-tools version bump). |
ivanvc
added a commit
to ivanvc/etcd-operator
that referenced
this pull request
Sep 10, 2025
…ules/tools/mod/sigs.k8s.io/controller-tools-0.19.0" This reverts commit 71fb5d3, reversing changes made to 89b8b94. Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
added a commit
to ivanvc/etcd-operator
that referenced
this pull request
Sep 10, 2025
Regenerate go.mod and go.sum, so go mod tidy has a clean exit. Properly updates the dependency identified by dependabot in pull request etcd-io#204. Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
added a commit
to ivanvc/etcd-operator
that referenced
this pull request
Sep 10, 2025
Adds google.golang.org/genproto/googleapis/api and google.golang.org/genproto/googleapis/rpc as indirect dependencies, so go mod has a clean exit. Follow up from pull request etcd-io#204. Signed-off-by: Ivan Valdes <[email protected]>
|
After merging #214, we should be good? |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps sigs.k8s.io/controller-tools from 0.18.0 to 0.19.0.
Release notes
Sourced from sigs.k8s.io/controller-tools's releases.
Commits
257e3a0Merge pull request #1268 from sbueringer/pr-promote-envtest-1.342b454eaPromotion of envtest release for Kubernetes v1.34.0650fc15Merge pull request #1266 from sbueringer/pr-bump-v0.343b0dd92Merge pull request #1267 from sbueringer/pr-envtest-0.341640706Release envtest v1.34.036f98efBump to k8s.io/* v0.34df911f1Merge pull request #1264 from kubernetes-sigs/dependabot/go_modules/all-go-mo...767291d🌱 Bump github.com/onsi/gomegab624019Merge pull request #1261 from mjlshen/webhook-testdatad53aa90Generate DeepCopy methods for testdata/cronjobDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)