Skip to content

Conversation

ANtutov
Copy link

@ANtutov ANtutov commented Sep 5, 2025

Fix incorrect "First" vs "Last" fork state comments in forkid tests

The fork ID logic shows the current blockchain state, not the next fork.
These comments were misleading developers about when forks activate:

  • Sepolia test: "first London block" → "last London block"
  • Holesky test: "First MergeNetsplit block" → "Last Paris block"
  • Holesky test: "First Shanghai block" → "Last Shanghai block"

These corrections align with the established pattern in mainnet tests
and accurately reflect the fork activation logic (fork_time <= current_time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant