Allow the PG_CONFIG environment variable to be used without overridin… #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g it Otherwise the following command will fail: $ PG_CONFIG=... make make: pg_config: No such file or directory make: *** No targets. Stop. Other methods still work: $ PATH=... make $ make PG_CONFIG=...
|
@eulerto, what do you think about this? |
|
@MarinaPolyakova I'm using the same pattern as contrib modules. It is also in the documentation. Are you planning to submit this change to Postgres? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g it
Otherwise the following command will fail:
$ PG_CONFIG=... make
make: pg_config: No such file or directory
make: *** No targets. Stop.
Other methods still work:
$ PATH=... make
$ make PG_CONFIG=...